Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mambaforge #3

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Remove mambaforge #3

merged 2 commits into from
Nov 2, 2024

Conversation

lilyminium
Copy link
Member

@lilyminium lilyminium commented Nov 1, 2024 •
edited
Loading

Fixes #2

Changes made in this Pull Request:

  • Removes Mambaforge
  • Switches to miniforge

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@lilyminium lilyminium mentioned this pull request Nov 1, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@25a3d27). Learn more about missing BASE report.

Additional details and impacted files

@lilyminium lilyminium marked this pull request as ready for review November 1, 2024 08:07
@lilyminium
Copy link
Member Author

@fiona-naughton if you have time to look this over, it should fix the CI failures in #1

RMeli
RMeli approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I had to deal with the same issue in a package I maintain.

@lilyminium lilyminium merged commit 0283c1f into main Nov 2, 2024
19 checks passed
@lilyminium lilyminium deleted the fix-mamba branch November 2, 2024 13:03
@lilyminium
Copy link
Member Author

Thanks for the review @RMeli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli approved these changes

@fiona-naughton fiona-naughton Awaiting requested review from fiona-naughton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mambaforge is dying and our CI has brownouts
2 participants
@lilyminium @RMeli