Addition of pytest case for not None values for frames and start/stop/step
#4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pytest case where both frames and start/stop/step are present to raise valueerror
Updated changelog to add coverage of raise error case where frames and start/stop/step are present
|
Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-10-28 09:06:37 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4769 +/- ##
========================================
Coverage 93.66% 93.66%
========================================
Files 177 177
Lines 21726 21726
Branches 3052 3052
========================================
Hits 20349 20349
Misses 930 930
Partials 447 447 ☔ View full report in Codecov by Sentry. |
talagayev
changed the title
pytest case for not None values for frames and start/stop/step
IAlibay
requested changes
Oct 28, 2024
removed Changelog change
|
now that I was working on a different Issue I noticed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4648
Changes made in this Pull Request:
pytestcase intest_base.pyto cover the case whereframesandstart/stop/stepare both specified as notNone, leading to anValueErrorPR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4769.org.readthedocs.build/en/4769/