Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deploy action for OIDC #72

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Update deploy action for OIDC #72

merged 3 commits into from
Nov 3, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 27, 2023

  1. Can't use pypi-deployment right now because of the odd format of the pyedr/panedr repo.
  2. This makes it a bigger action, hopefully will be cleaned up when pypi-deployment is fixed to handle this repo.

@IAlibay IAlibay mentioned this pull request Oct 27, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b1b3c4) 99.74% compared to head (67c7b2f) 99.74%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           5        5           
  Lines         385      385           
=======================================
  Hits          384      384           
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay requested a review from orbeckst November 3, 2023 11:32
orbeckst
orbeckst approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing the custom update

@IAlibay IAlibay merged commit 8498b14 into master Nov 3, 2023
11 checks passed
@IAlibay IAlibay deleted the oidc-deploy branch November 3, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IAlibay @orbeckst