Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated default processing date #163

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Updated default processing date #163

merged 1 commit into from
Sep 20, 2023

Conversation

ehanson8
Copy link
Contributor

Helpful background context

Updating the default processing date to 2 days before the current date to address an issue that has appeared since the August release of Alma. This change was approved by stakeholders in Technical Services.

Includes new or updated dependencies?

YES

What are the relevant tickets?

Developer

  • All new ENV is documented in README (or there is none)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

@ehanson8
Updated default processing date
fee40bb 
* Update default processing date to 2 days before the current date and update CLI test
*Update dependencies
adamshire123
adamshire123 approved these changes Sep 20, 2023
View reviewed changes
Copy link

@adamshire123 adamshire123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it! :shipit:

@ehanson8 ehanson8 merged commit 4d06481 into main Sep 20, 2023
3 checks passed
@ehanson8 ehanson8 deleted the processing-date-change branch September 20, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamshire123 adamshire123 adamshire123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehanson8 @adamshire123