Maintenance week updates #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace setup.cfg with pyproject.toml * Uninstall legacy linters and install current linters * Add new linting commands to Makefile * Add help command to Makefile * Install pre-commit and add config yaml
* Updates to type hinting, code structure, datetime objects, unit tests, fixtures, and docstrings as requested by linters
ghukill
approved these changes
Dec 6, 2023
jonavellecuerdo
requested changes
Dec 6, 2023
* Remove lambda-related Makefile commands * Replace caplog.at_level with caplog.set_level in CLI test * Remove coverage from Pipfile
Pull Request Test Coverage Report for Build 7119503500
💛 - Coveralls |
jonavellecuerdo
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates app according to our maintenance week documentation
How can a reviewer manually see the effects of these changes?
Run
make run-devto run the app against our Alma sandbox API. This doesn't have any data to generate credit card slips but you can see that app executes properly and sends a notification email to our dev1 addressI also verified the changes by running manually against Alma prod for 2023-12-04 and observed that the email attachment matched today's email attachment for the same date.
Includes new or updated dependencies?
YES
Developer
Code Reviewer