Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 1065 maintenance 09 2024 #272

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Commits on Sep 19, 2024

  1. Maintenance updates

    * Update Python version to 3.12
    * Update Python dependencies
    * Update pyproject.toml and add Ruff rule G004 to 'ignore' list
    * Clean up section headers in Makefile
    * Update 'Environment Variables' and description in README
    jonavellecuerdo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    da3d1d9 View commit details
    Browse the repository at this point in the history
  2. Update Config module to current conventions

    Why these changes are being introduced:
    * Use a central Config class for dynamic access to
    environment variables and simplify method for configuring
    loggers.
    
    How this addresses that need:
    * Create a Config class for dynamically accessing environment variables
    * Deprecate load_alma_config and update AlmaClient to use Config class to dynamically
    set attributes (base_url, headers, timeout)
    * Update configure_logger to use 'verbose' boolean flag
    * Update CLI to accept '-v/--verbose' boolean option and remove '-l/--log-level' string option
    * Add/update corresponding unit tests
    
    Side effects of this change:
    * Remove LOG_LEVEL as an optional environment variable
    
    Relevant ticket(s):
    * https://mitlibraries.atlassian.net/browse/IN-1065
    jonavellecuerdo committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bb3bd47 View commit details
    Browse the repository at this point in the history