Maintenance 09 2024 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to 3.12 in .python-version, Dockerfile, and Pipfile * Add help command to Makefile * Update and reorder dependencies in Pipfile * Update pyproject.toml
ghukill
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Before diving into the rest of the PR (which looks great at a glance, not anticipating any requests), did have one.
While attempting to run a local harvest test via:
make dist-local
make run-harvest-localIt was discovered that the testing configurations here are pointing at a version of the website no longer available.
A more stable version was shared, which would allow updating that YAML to the following:
generateCDX: true
generateWACZ: true
text: to-pages
# prevent PAGES from getting crawled; scoping
exclude:
- ".*lib.mit.edu/search/.*"
- ".*mit.primo.exlibrisgroup.com/.*"
# prevent RESOURCES / ASSETS from getting retrieved; URL requests
blockRules:
- ".*googlevideo.com.*"
- ".*cdn.libraries.mit.edu/media/.*"
- "\\.(jpg|png)$"
depth: 1
maxPageLimit: 20
timeout: 30
scopeType: "domain"
seeds:
- url: https://www-test.libraries.mit.edu/sitemap.xml
sitemap: https://www-test.libraries.mit.edu/sitemap.xmlCan we make this change? Thanks!
|
@ghukill Good catch, made the change! |
ghukill
approved these changes
Sep 11, 2024
jonavellecuerdo
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Updates app according to our maintenance week documentation.
How can a reviewer manually see the effects of these changes?
Run
make testandmake lintto confirm they still passIncludes new or updated dependencies?
YES
Changes expectations for external applications?
NO
Developer
Code Reviewer(s)