Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prod Makefile commands #38

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add prod Makefile commands #38

merged 1 commit into from
Oct 26, 2023

Conversation

ehanson8
Copy link
Contributor

@ehanson8 ehanson8 commented Oct 23, 2023 •
edited
Loading

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)

How can a reviewer manually see the effects of these changes?

make verify-dspace-connection-prod can be safely tested with the dssManagement policy.

NOTE The Prod-Workloads instance of DSS is now active and running make run-prod will process any messages in the dss-input-prod SQS queue and update our production DSpace instance.

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

@ehanson8
Add prod Makefile commands
f5348cb 
* Add Makefile commands for prod environment
@ehanson8 ehanson8 marked this pull request as ready for review October 25, 2023 14:07
ghukill
ghukill approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@ghukill ghukill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Able to run the connection test in prod successfully.

@ehanson8 ehanson8 merged commit e8264ee into main Oct 26, 2023
3 checks passed
@ehanson8 ehanson8 deleted the makefile-prod-updates branch October 26, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghukill ghukill ghukill approved these changes

@JPrevost JPrevost Awaiting requested review from JPrevost

@jazairi jazairi Awaiting requested review from jazairi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehanson8 @ghukill