From 1f4c899562842562ecf24968a1f3cc03b63404f1 Mon Sep 17 00:00:00 2001 From: Matthew Bernhardt Date: Fri, 16 Jun 2023 17:18:36 -0400 Subject: [PATCH 1/8] Make display of interview player conditional ** Why are these changes being introduced: * There are some interview records which don't have a video component on YouTube. Currently, we cannot use the Interview display for these because the template always shows a YouTube player, even when there is no video. Which errors. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/lm-421 ** How does this address that need: * This wraps the YouTube player iframe in a conditional check to make sure that there's a youtube ID in the record. If there isn't the player is skipped. ** Document any side effects to this change: * None Oops - rebase into youtube --- web/app/themes/mitlib-child/single-interview.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/web/app/themes/mitlib-child/single-interview.php b/web/app/themes/mitlib-child/single-interview.php index 252e0198..d2294311 100644 --- a/web/app/themes/mitlib-child/single-interview.php +++ b/web/app/themes/mitlib-child/single-interview.php @@ -148,10 +148,12 @@
-
- - -
+ +
+ + +
+
From b252751ddf6d31071d3513aad8a94e5db3cd2424 Mon Sep 17 00:00:00 2001 From: Matthew Bernhardt Date: Fri, 16 Jun 2023 17:33:17 -0400 Subject: [PATCH 2/8] Add commas between tag values Add margin below the metadata lists in titlebar Bump theme version because stylesheet changes --- web/app/themes/mitlib-child/css/scss/interviews.scss | 10 ++++++++++ web/app/themes/mitlib-child/style.css | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/web/app/themes/mitlib-child/css/scss/interviews.scss b/web/app/themes/mitlib-child/css/scss/interviews.scss index a7688c5d..b158e72a 100644 --- a/web/app/themes/mitlib-child/css/scss/interviews.scss +++ b/web/app/themes/mitlib-child/css/scss/interviews.scss @@ -6,11 +6,21 @@ background: #f2f0f0; .list-inline { + margin-bottom: 12px; margin-top: 12px; &.links li { margin-right: 12px; } + + &.tags li::after { + content: ', '; + } + + &.tags li:first-child::after, + &.tags li:last-child::after { + content: none; + } } .post-thumbnail { diff --git a/web/app/themes/mitlib-child/style.css b/web/app/themes/mitlib-child/style.css index 5c54a19f..dd7baf53 100644 --- a/web/app/themes/mitlib-child/style.css +++ b/web/app/themes/mitlib-child/style.css @@ -1,7 +1,7 @@ /* Theme Name: MITlib Child Author: MIT Libraries -Version: 1.0.0 +Version: 1.0.1 Description: A child theme of the MIT Libraries' parent, focused on sites built primarily with static pages. Template: mitlib-parent From e855cdcbecbdae6a070afc8ecaa8f226da800518 Mon Sep 17 00:00:00 2001 From: Matthew Bernhardt Date: Tue, 20 Jun 2023 13:24:02 -0400 Subject: [PATCH 3/8] Remove "no photo" image from child theme The MOH site had a feature where we would load the Libraries' logo if an interviewee had no headshot in our system. The logo we were using was out of date, and we've decided we do not want this feature anyway. This removes that default use of an image when no headshot is defined. --- web/app/themes/mitlib-child/images/no-photo.png | Bin 8008 -> 0 bytes web/app/themes/mitlib-child/single-interview.php | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) delete mode 100644 web/app/themes/mitlib-child/images/no-photo.png diff --git a/web/app/themes/mitlib-child/images/no-photo.png b/web/app/themes/mitlib-child/images/no-photo.png deleted file mode 100644 index be7cdafdd285ae0e64f3c16e3c4749ecfa86d45e..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 8008 zcmcJUbx>Q;+U{wKOR?h8;w?_GLXhGVic3=@NQ+x>hvEf_Tk+x)r$CS(rML!4(Lg9g zf&>Bt2p0G_Gv~~lJ9F;bx%YnGAA6ozd)9tt&Aa!!`&sK3tE;U>M$AZzgM&l%N?lnW z2j?FD-Sv_X|LzXHrh?&}FnFl|y$sxJy?m`aY;Y9byII>jdF5hdXQOXp_1@oo#6|`O zhjsUrvVx)C5;C78-Q3832s8fv_#s7Va-`ZP3fx$BUKPD3kNm68aaHtoBj$GX8%-L` zU9!p?Yk@9Ch7F(o!UU&_KM6fD)K$R4jl}V%U=8EMJq~&Od2y z5T{_LgDy{0JEEWo8XCIV+S8>o|KrC?9Gq?34k=umkCyjvo&f(PIE1wS82v+V!twqk z|Cn<(`hTAK&jT{xzklWbX8v#W_-A$gw`KYKfV=s43?sFzKKWz&R|YT%8mKdQ zrtS=~_H=Hdg3W;6ocL*2r%~mu^<-<+9Iim9VVMh){XU%F#n9G;f@YTn*_4Hx{<%xk zdhGtO&-1YYjHjboq4<~^lSMe5meT#_QdHEkaLL99Dwt5?11i{Rl1-D^w^}X6H3?1+ zau{ozvyF8%J7u~{E7=tDVZ+y8#Y@?JmVGOo?LYkwwUEjE4__mnon;Q*pTWW&3LJ&{ ze;A_?x( z5WYtFMbWXJ6KW17gtVXYu=`vBUN118`wMKtb~g_VwX$Tj7vqcP-*AG(8Ug&a)z>*P z&H2m{xFn;ZfMW_;SVTZolvDE#S_QJgW>~0HcTXPbp#&+8hm4_iFz-Z0iuPX87YvQw zNKVu89P%XnbPI~x7n5JLyayR7SXen5%$ydZ1`sd-TOqW?Ak= zNzO9_o4{ZmLzG4taI14fAE9?}8r2|c2eI$wI8f$RDMCDo$)*w}b7rQ+CwRddm6OZj zv0AVoNp)2RND$HDBUYoV8MMINZL!E*kUAKsKqx!@0I!65LH3Q~XU~S?w@Dt!fq9R& z6P&yIFdT|GPU#cJ7n8m(sdzWL>$H$@{UI!a_FQt|v)L!W^bM^pKqGaDt|^(grWqgf z1k&%Sjie3K17Hh6BEP+pE**cw$ZBJddUGiJ#Wa_~Tl+X!=oJ!n_H*#{G;jFq+e&xd z*gzj^1guH_OJ+iwfG>&{GLk?u2!2z(aqZdnr_xR0fr5*Q)IdFt&o@BzDIsmRIHNtT zhPXb0>x{978|4rcwe#i%MkKq_{}h?6d-x*v=?V)z&#S!)vD;9`NzpvUX!4EWz-7iL z6?3Z(-K&|xUW%TfC!NrwD`Hj@k|N1)e`BFP5&ez~Y`<}w6&pO6zetQr((8zSC5;TU zQcv4vT0X4PK@KL*Nwkop@$-uEvwt6%e#dodXByPh{zzHO5L3?J?wj_Uj5J}+k7UzxT{1>Bt%Opx8Zyr-$eFL zY)P>Ru>Tf5a}ikP@qgCj9BBIS?8M^qkLOQIvR}?Ua-xQy`{f3UE|h5>9g01{{0T_C z7>n#F*#pF$;^`*kgyS2Yr3VHA^8!{4&Smw~52eFrL!Kh_^eW1S>Q37w393PW^ z?&ul=H5@4MhjN+7A#s}Z@9_}-J zfr;5%rV+-J4RtZR3hnn7pOU;Fkc-&0g z&>P!5kjt>_q+|Z~SyqXt-dsu2M}$i+X|9apE4?!OWu^;u-p2!tP0O{dq2WDmvtyin z=*^xq@R8;lQ=2w*HneSNm5d|a4riLQ8HS!ZJ;pebiTvneq&(7MO^=Y~Xq-_pQC@m2 zvdd>Rn*V;!%!b1xNfj#UzN9#F6H4x8%xS4ng`&nzs9M>nz|G+SIc=e){Ge5G2g+j; z-zO|0tI5(eXGG{N)ARz=b$=|`nX2zyfvW%FopQ=CYRo5Ja!8rR--yxpyDip2&svfP zT9wCWi9XNIJDz-uO~uSh2brx+esiG%DmR#n-A5Fr^UI5tQUjT$BL-()NwiT`iP&O( z2Tp+*ChVQKmH%ceD)wYfh<$P?UABX2vVO^Q0Kr`g=)%P>$K5M^o4YExyj^)T>ukXi zr0_pzg+Q%piZT(+RzN2nZNmfX3qHe%gL3ow6irl*g(pfBMu<(MIyPwNZ2U3 zcGYytDh1J0RbEB&XlT32qxVQA{48S-1%8EzO|eAJ;J$-a3zK3_LyuhZhedYW>UR55 z)r(5RBCX*OgTJ!oe!=Qve6(h^dMzR#Qu>SYy|Mm1oC=QSy6YmNxG%rRs?hoq^Ev_` z!Z~^h{uR%IjE7f=m4~4ACEo>3Lk%B!N7%48zSetvdTC!Vi2K0|wso28`S;ihd3B^y z$*l2R!!6?6-lGasQAZ#r`23PW+RF9cYtpVdVWdSf`J;_Xa++$YKn1`|H(6d%<0V9w zV9PtM-Fi|jkU4HIqg2QG2;`?_t)ZDst^R#3fu>w5-u^M#s1jEq>3cN4Y~%SSTm2lw zOe0i0J@Ok>OUj;REua+}med=Xi!d=_VS;x}b>>hYalaljGUiyI9@hu_%0oIA`HZJp zfwR^&AY4W3DS5T{hCJ&pCMz*#aYEc`3B%!vlx`C2o65YGD!wL^CvdALJ5bn}F69kIWL){uhw!@-k-F*D*;KIk-IykmVqI7Q*BYB>;{0H?3qv=a9M<(gj zYFSHO4$%&M(YVQR-Q7if_33uk_ci&>ubDzk=lU;apT$uZa{TJC|dr$cikI%$?1z>q))}SrNbD zM-^sP-Y{h8%p%hk;#YRw*ECux5D*#rX0T?ySXR_~#Y_te+^y1Q9*tEkgL+9mtKl{z z*ghm#Kjc-}p5k34h`7HDvt?NXc1|7-wZ-)P@@F*`kSQT%OSKcvoiU*%zGC(G1o(6J zZY^1`s>N3~vdE!D_u%lp=U}`&3XDF4&(CT`s#d&+glFvH**zJlMw_CrR95~(ACOpm9u?izUsFjshT6Q7v zPHi{(Z!w}O>r&a8Ad8|yk_+7Uvf%{qxT*5q%NXKJLF52U$XKTyydne4zM5bL+~?{RM;IShGhxiwg1wgQRxe5SD;J|bOLbB;8Ejf6kBu98h)LW8&OfKZ(md+FWo{?2d2?@^< z3~W9*c5R(qNEEX;xC=LpJT)$kb>$xZcj}tLG8VR_$eSO>gc}Vdh=OUoR+7x^6K z^us~LS{r&SOLi`s8n)UGcX(+TZYh4zD1Z0rhjqE7m0+#~18P>W-^~b29m>d5NQHEe zZi*(4%wx-9&7D)sEC#M-M>>12x*Nu?;QL||^4w>$jDRM0HlT+R%J*H4;UBBb?DdF3 zyIdXi^a>#!Wk?l8HH+NVn`p1uIMUP6Dy1<5qurIYH2nUXN5_aBNwnqUcfScf`<|5) zo?`4dIf;6Ka}PH{TB)U;1R2#c0=J}ukVI7r1V)~>xXXnX8TBpIbQXA7xXebTK6|S zIWHSf^Fi5z397cJvro?(FT46uuYyJP*9U_Qt#xAMuBZY{P^3E@CYuYJ6nn>c81Q0I z(x_^|i4za^S%$D!Qu`oiGM}wB7-q9(*p1ExlSY{oY9hyVR~X+d#fU1J#L(#wz&3)H z);`p-Zb3MJsU&QtrUxIsbj=jy$%s!h1&5r#vjEpJe54jL0wg-}xzv1JDEyd_B&pJQ zsgTUp6&ioj)}@(UwFZ1Vr)(x0P{Y~ry(BeCI@(Sh*#VcZGLxJz!Dw`F3P$Slm1Qg| z7VjY)^b;u1Ts@2U(l{Hn;NpfHNCECxU$zS^#qbkr3MA4Y`Zc^=ACE-2i%XHxik9E0iN;1fdm_gr;Y|;&NS+3BX7Kl)i&bVH{VT&*fzK>&=5hp(+V$`zQ%{TntS*xi+Q767|3tJclATKe& zPUE(xAIPxzf~O-y?f|+B`}mHJEhyMk9!kEc2AKyGf@iE#iN*k37EGS=&{VTFUp=D6 zQ7|?{O`_sl+<%<$q|LRN3FON}GPg@5*y2GEL(_kyvdju(s?OfNkA2C|I0{6>vp>|) zZpt!0$jzbGfx_+Dq_TVa*v91 zgB>P$SaR&_OOH2}1J5R+wl&H_OMd#$1UTU>`*EIb7>l*}(9{S9s`F_^a>Q%}Tw#gf z711H&;j@O_7G=V?F&anTM`x6dKDiZCBYV>|^ql}hTQcD$s?iw|=SsaQ=48C4=fDR^ zi2E^93^~BiV6wv1we=Q(xUbqmghyxN-qOKFtQ9TO=mEmH51G+xN|n3b>#wG$s<9+; zffh8f^1q?)ioo70gUbMbTwdIP~4sLs?k6%Gj^ z_j^g-(H6@5P!a7XOgh0~+&6kZ$=Z=#ZllosO=V|d`p*f;OZMLbt<{N%j!G;&w}bf6 zVGQV>Q`1v0#r@cQh(}LoCLjt)??$YoW+xs8m>6ngX3XxKva$`OK|S^j7w=`A<9=NF zMRs}N%_1Zx!ZJa+TInLv|CyUAIIFO_|LZdQr=-YVe4zIy^No-FcaKt=+ z(orUSW4-_{(``f-{NO>#p-i4;4rXcO1FO=7n~ zi5;+uk-Uipq3;Qed%I=z6&oHNuSanOtU#tR${Sa@LTi!3QG98N7b7izoG-3l>`{sm z?TIeVqzU;!8j<4PFU zF(1?Pongr&^Wd3q2YTv}$HD%ipN1Bno3KG0S_Km%us>hU9uaE#(wkw6GLwaSR<4quYK65bmx%nd$ZTj!TE3OT zmz61>I%WQBIhj_XYI*I`Fq4~Ioa&yTd4bSzP2{LQEdmTE`xCr+w0FxGop_#anKo4R zO}mGb14@|~*h^K#H7!$7%*byf-NYS$-mVulV;bI+!)IhRcIekMTB~oOgYV?QHugg& zp3&8oyQ?0A+QGVaFy;xCMnmRBexUi+n6GIXen3KFPdul<-2ItqqyRrJ#R!ZU|JmAY zWLKYDZX{-0*k}Ir%qQn|=9N=9ImFv1Nu$`?Svffi_sX`;4Eb_uT+NcmBsxERf~a4T zT3t+93~wsef0^|KdlaS6Vy>*z$KHvh_cV^HtR#k?I`}T6sWp%h9iw3Iuhv~ffA*J=bca~3OxsKUqBO@<(_fm>~|LD2v ztxe1~f~1AF#&JGfY{OYq6uGM3f0r{nFyUGcZg+a^-&=3GZ2EoDtfJ=qR}iez*Do0u67DJ(@(CP?=`9H>_?L`n=X8qqH9~8m#M5)r(7g)`{>h~{gqPM zb2DG63f_C)%R7)?6s6ggNX?y2G&Ck6!UH5$QB8Hq+o0gy+6|AdF>pBT58ece?eBQv z<@fIp8v9dLfvr}fEX7$i4R_leT)JO)l-?Z=BFw)%J`wB`awS3;J%y{$lBRy^JSjb~F0F7ne>=l>fxD)pq@A zoVQ=?HF7o3T#oy{?SGpNdojrbC@gqHN+8RXP9jD5*wbglPW3`cH@4KNmYeMj# z`Eo18<*$3~q->}w3n;U5@`X-iP7_T?=U9(Rv1|j@kq|JyB^{BeY?sdo^fjJtqpX=$ znvu%uc1V9 z52n|7JnzewMWgAU4$D(r3Nn`Z zqDkCYZ49F0>pQe5U8RhMdp0mLiUey3jzicn1vc%8w-ZLuKPsY&(n>?aEHl(*_ma{t zLM;>?TJq2A!QE4C=d5F5mNNN?+EoRMfOh16tYeHeJ$N5CSPm5Qlm8r6^V}rDa%SNt z^L&NKKi1#!><9)LHwuV#&|OzkVb9$&9#-2l5^ zNpg_4eOdua3mR|Fbw&96l^GYf`OJMeID*KQ>xP(o0C^(?G2Ng?ENCoqcb5$5oc6PH z*jf9pEVO)KUaGWz;?~-Kj|+?l>a`oEYFJPq?jGwxcxHA z^z8gbS7xWZIx)Ge0Q$(~o#KO}z&8=l`IoV)hK`B0%YE8scqL4}j_C(|Y+Y&7dAc2P zc1=tjKXV0)SYeKRb382HhsSOp%V&20Vk6()`@UArT&gH^bklu{wmGbhvfLoR(f*z3 z3gs~D(ozr#_N6xo%2i|g>Ut318MW@+-L*`@f${}Cm5*3^2OcuvqBno=pq7t#74elr zi2ub=T5xe4Ss#yx=KiYg*MnUaanajWJPT21*HB_OsvXXzB&Sy|GtAU?SPIs@+nWT) zcWZRj2h=uUu@DckH*_NzMc~p4{=h8JzF`7duW@-43U!7TnAgg8)YOI zu};xBM%T7=@@y?QQmINXuoLsbqAcnUYt4scFTja`K>3nTt>Fg)vL2`6t}@R&w0{+} z35==qlq9b1X8M&Hmp^?WH_bZm5zte(apoNcMM$`z?OZEnJ>q1$ID ); $interviewee_mit = get_field( 'mit-affiliation', $interviewee->ID ); - $interviewee_thumbnail = 'No Photo'; + $interviewee_thumbnail = ''; if ( get_the_post_thumbnail( $interviewee->ID, 'thumbnail' ) ) { $interviewee_thumbnail = get_the_post_thumbnail( $interviewee->ID, 'thumbnail' ); } From b355a169442f41de0428dec04c7869b621f34205 Mon Sep 17 00:00:00 2001 From: Matthew Bernhardt Date: Tue, 20 Jun 2023 13:25:42 -0400 Subject: [PATCH 4/8] Restructure page headings on singler interview template The heading structure used by the Interview template had some poor choices, with a poorly placed h2 and the primary heading being marked as an h3 (which is a peer to some internal headings farther down). This rationalizes the heading structure a bit, but does not touch the much larger problem of using the organization name as the h1 - which still needs to be changed, but this is not the ticket for that work. --- web/app/themes/mitlib-child/single-interview.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/app/themes/mitlib-child/single-interview.php b/web/app/themes/mitlib-child/single-interview.php index 8b9719b7..48ece54d 100644 --- a/web/app/themes/mitlib-child/single-interview.php +++ b/web/app/themes/mitlib-child/single-interview.php @@ -75,7 +75,7 @@
-

+

@@ -137,8 +137,8 @@