From 1a08b23a4c6a3ef9d1bd0b437876cd4a5b5bcd85 Mon Sep 17 00:00:00 2001
From: Matthew Bernhardt <mjbernha@mit.edu>
Date: Thu, 31 Aug 2023 12:26:49 -0400
Subject: [PATCH 1/2] Adds tag template to News theme

** Why are these changes being introduced:

* DSpace@MIT currently sends traffic to a page showing all news articles
  with a specific "dspacemit" tag - the only such example of a tag index
  on the site. Unfortunately, this tag index is not displaying correctly
  due to a bug in the parent theme's tag template.
* On the legacy site, this display functions, but is a poor fit for the
  need because the display isn't branded correctly (it is partially
  branded with the parent theme)

** Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/pw-55

** How does this address that need:

* This adds a tag template to the News theme. It repeats the structure
  of the legacy display, being a paginated list of complete articles,
  instead of the category index that shows an AJAX-paginated list of
  cards.
* There is a small change to content-single.php in the News theme, which
  we realized was previously unused. Now it is used by the tag template,
  but we need to change one class to control how the article metadata is
  displayed (the former class name results in an absolutely-positioned
  element on screen, which was useful in a card display but is a bug
  here).
* The news styles are updated to ensure that large images don't overflow
  their container, and to add some padding around each news article in
  the list.
* The parent styles are updated to ensure that pagination links are
  placed alongside each other.
* The news theme version is bumped to 0.3.0. This is a nice-to-have,
  not required by the style changes as the changed stylesheets are not
  compiled by SCSS.

** Document any side effects to this change:

* The page structure we're using for the tag index is a new visual
  approach, but the work to provide an AJAX-powerd paginated list of
  cards would have been higher, and isn't justified by how little use
  this template will likely see.
---
 web/app/themes/mitlib-news/content-single.php |  2 +-
 web/app/themes/mitlib-news/style.css          |  9 ++++-
 web/app/themes/mitlib-news/tag.php            | 34 +++++++++++++++++++
 web/app/themes/mitlib-parent/style.css        |  4 +--
 4 files changed, 45 insertions(+), 4 deletions(-)
 create mode 100644 web/app/themes/mitlib-news/tag.php

diff --git a/web/app/themes/mitlib-news/content-single.php b/web/app/themes/mitlib-news/content-single.php
index f3c01560..0f863a21 100644
--- a/web/app/themes/mitlib-news/content-single.php
+++ b/web/app/themes/mitlib-news/content-single.php
@@ -33,7 +33,7 @@
 				?>
 			</span>
 			<?php if ( has_category() ) : ?>
-			<span class="category-post">
+			<span class="category-post-single">
 		   
 				<?php
 				$category = get_the_category();
diff --git a/web/app/themes/mitlib-news/style.css b/web/app/themes/mitlib-news/style.css
index 5872771c..7dba51fb 100644
--- a/web/app/themes/mitlib-news/style.css
+++ b/web/app/themes/mitlib-news/style.css
@@ -1,7 +1,7 @@
 /*
 Theme Name: MITlib News
 Author: MIT Libraries
-Version: 0.2.0
+Version: 0.3.0
 Description: A child theme of the MIT Libraries' parent, focused on News features and content.
 Template: mitlib-parent
 
@@ -832,6 +832,9 @@ h2.grid {
 	padding: 0px;
 	padding-left: 8px;
 }
+.mitContent {
+	overflow: auto;
+}
 .mitContent h2, .mitContent h3, .mitContent h4 {
 	margin: 0px;
 	padding: 0px;
@@ -872,6 +875,10 @@ article {
 	padding-left: 20px;
 	padding-right: 20px
 }
+.tag article {
+	padding-top: 10px;
+	margin-bottom: 20px;
+}
 .classCheck:nth-child(n+4) {
     display: none;
 }
diff --git a/web/app/themes/mitlib-news/tag.php b/web/app/themes/mitlib-news/tag.php
new file mode 100644
index 00000000..ba6579b5
--- /dev/null
+++ b/web/app/themes/mitlib-news/tag.php
@@ -0,0 +1,34 @@
+<?php
+/**
+ * The template for displaying all content with a single tag.
+ *
+ * @package MITlib_News
+ * @since 0.3.0
+ */
+
+namespace Mitlib\News;
+
+get_header();
+?>
+
+<?php get_template_part( 'inc/sub-header' ); ?>
+
+<div id="content" role="main">
+	<?php if ( have_posts() ) : ?>
+		<div class="container container-fluid">
+			<div class="row">
+				<h1 class="lib-header">Tag: <strong><?php echo esc_html( single_tag_title( '', false ) ); ?></strong></h1>
+				<?php
+				while ( have_posts() ) :
+					the_post();
+					get_template_part( 'content', 'single' );
+				endwhile;
+				?>
+				<?php \Mitlib\Parent\content_nav( 'nav-below' ); ?>
+			</div>
+		</div>
+	<?php endif; ?>
+</div><!-- #content -->
+
+<div class="container">
+<?php get_footer(); ?>
diff --git a/web/app/themes/mitlib-parent/style.css b/web/app/themes/mitlib-parent/style.css
index 323aae8c..07504fba 100644
--- a/web/app/themes/mitlib-parent/style.css
+++ b/web/app/themes/mitlib-parent/style.css
@@ -443,7 +443,7 @@ img.wp-smiley,
 .nav-previous,
 .previous-image {
 	float: left;
-	width: 50%;
+	width: 48%;
 }
 .meta-nav {
 	position: relative;
@@ -454,7 +454,7 @@ img.wp-smiley,
 .next-image {
 	float: right;
 	text-align: right;
-	width: 50%;
+	width: 48%;
 }
 .nav-single + .comments-area,
 #comment-nav-above {

From 2c718160a3fe167908a58ef29e08ee62ca285972 Mon Sep 17 00:00:00 2001
From: Matthew Bernhardt <mjbernha@mit.edu>
Date: Thu, 31 Aug 2023 16:50:13 -0400
Subject: [PATCH 2/2] Stretch goal: refactoring content-single.php

** Why are these changes being introduced:

* As we are now using content-single.php (and discovering that it was
  unused before), we are discovering that there is a pretty significant
  amount of debt in the template - unused conditionals, references to
  fields that no longer exist, etc. That made working with this template
  a bit trickier than needed because it wasn't clear what was needed.

** Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/pw-55

** How does this address that need:

* This refactors the template, removing unused variables, unused
  conditionals, etc. Full details are below.
* The mark_as_new field no longer exists, so that check is removed.
* The article category is not shown, and the old logic never actually
  displayed it - so we remove it entirely.
* There are no "features" or "updates" post types on the network, and
  the "exhibits" post type is not used on the News site - so those
  checks are also removed.
* The bespoke handling of event date and time information is removed in
  favor an existing partial that is used elsewhere in the theme. While
  we don't anticipate any event information to be displayed using this
  template (The DSpace@MIT tag has always been news articles written by
  our staf, and not event records imported from the central MIT
  calendar), this will protect us in the future if that changes.
* Whitespace is cleaned up, and references to $subtitle and $type
  variables that are never used are removed.

** Document any side effects to this change:

* None, unless I've missed a path somewhere in the theme where this
  partial is loaded somewhere other than tag.php. If that is the case,
  then there will likely be an impact in how content is rendered that
  I have not seen or considered.
---
 web/app/themes/mitlib-news/content-single.php | 79 +++----------------
 1 file changed, 12 insertions(+), 67 deletions(-)

diff --git a/web/app/themes/mitlib-news/content-single.php b/web/app/themes/mitlib-news/content-single.php
index 0f863a21..9a91768d 100644
--- a/web/app/themes/mitlib-news/content-single.php
+++ b/web/app/themes/mitlib-news/content-single.php
@@ -8,85 +8,30 @@
 
 namespace Mitlib\News;
 
-	$category = get_the_category();
-	$type_post = get_post_type();
-	$subtitle;
-	$type;
+$category = get_the_category();
+$type_post = get_post_type();
 ?>
 
 <article id="post-<?php the_ID(); ?>" <?php post_class(); ?> data-category="<?php echo esc_attr( $category[0]->slug ); ?>">
-	<div class="title-page  mySingle">
-		<?php if ( get_field( 'mark_as_new' ) === true ) : ?>
-		<span>New!</span>
-		<?php endif; ?>
+	<div class="title-page mySingle">
 		<?php the_title( '<h1 class="entry-title">', '</h1>' ); ?>
-		
-
 		<div class="entry-meta">
 			<span class="author">
 				By <?php the_author_posts_link(); ?>
 			</span>
 			<span class="date-post">
-				<?php
-				echo ' on ';
-				the_date();
-				?>
-			</span>
-			<?php if ( has_category() ) : ?>
-			<span class="category-post-single">
-		   
-				<?php
-				$category = get_the_category();
-				?>
-				
-				
-				
-			 
+				on <?php the_date(); ?>
 			</span>
-			<?php endif; ?>
 		</div><!-- .entry-meta -->
 	</div><!-- .title-page -->
 
 	<div class="entry-content mitContent">
-	
-		
-		 <?php
-			the_content();
-			// Echo type of Feature, if Feature.
-			if ( 'features' === $type_post ) {
-				$type = get_field( 'feature_type' );
-				echo 'The feature type is' . esc_html( $type );
-			}
-			// Echo start/end dates, if they exist.
-			if ( 'exhibits' === $type_post || 'updates' === $type_post ) {
-				$date_start = get_field( 'date_start' );
-				$date_end = get_field( 'date_end' );
-				echo '<div>Start date is ' . esc_html( $date_start ) . '</div>';
-				echo '<div>End date is ' . esc_html( $date_end ) . '</div>';
-			}
-			?>
-			
-			
-			<?php
-
-			$date = \DateTime::createFromFormat( 'Ymd', get_field( 'event_date' ) );
-			// echo $date->format('d-m-Y');
-			// Check for events.
-			if ( 'post' == $type_post && 1 == get_field( 'is_event' ) ) {
-				?>
-			
-			<div class="event"><span class="grey">Event date </span> <?php echo esc_html( $date->format( 'F, j Y' ) ); ?><span class="grey"> starting at</span> <?php echo esc_html( get_field( 'event_start_time' ) ); ?> <span class="grey">
-																				<?php
-																				if ( get_field( 'event_end_time' ) != '' ) {
-																					?>
-				 and ending at</span> <?php echo esc_html( get_field( 'event_end_time' ) ); } ?></div>
-				
-		
-				<?php
-			}
-			?>
-			
-
-	</div><!-- .entry-content -->
-
+		<?php
+		the_content();
+
+		if ( 'post' == $type_post && 1 == get_field( 'is_event' ) ) {
+			get_template_part( 'inc/events' );
+		}
+		?>
+	</div>
 </article><!-- #post-## -->