Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove documentation on confirming plugins work #132

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

matt-bernhardt
Copy link
Member

@matt-bernhardt matt-bernhardt commented Jul 5, 2023

Why are these changes being introduced:

The how-to page on confirming whether all of our various plugins are working is something that the UX group has indicated an interest in helping to maintain, and the testing itself will be followed by both engineers and site builders.

Given this, it makes sense to move this documentation to the service documentation in Confluence.

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/lm-60

How does this address that need:

This removes the stub page on confirming plugin operation, as the content has been moved to the Confluence space. This isn't a link that needs to be maintained in this way.

(We will eventually want to make sure that this repo links to the Confluence space at some level, but with the service being renamed soon I'm not sure what URLs will be changing in the next few days. We'll need a separate PR soon-ish once that happens)

Document any side effects to this change:

None

Developer

Stylesheets

  • Any theme or plugin whose stylesheets have changed has had its version
    string incremented.

Secrets

  • All new secrets have been added to Pantheon tiers
  • Relevant secrets have been updated in Github Actions
  • All new secrets documented in README
  • No secrets are affected by this work

Documentation

  • Project documentation has been updated
  • No documentation changes are needed

Accessibility

  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)

Stakeholder approval

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies

NO dependencies are updated

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • The changes have been verified
  • The documentation has been updated or is unnecessary
  • New dependencies are appropriate or there were no changes

** Why are these changes being introduced:

* The how-to page on confirming whether all of our various plugins are
  working is something that the UX group has indicated an interest in
  helping to maintain, and the testing itself will be followed by both
  engineers and site builders.

  Given this, it makes sense to move this documentation to the service
  documentation in Confluence.

** Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/lm-60

** How does this address that need:

* This removes the stub page on confirming plugin operation, as the
  content has been moved to the Confluence space. This isn't a link that
  needs to be maintained in this way.

** Document any side effects to this change:

* None
@jazairi jazairi self-assigned this Jul 5, 2023
@matt-bernhardt
Copy link
Member Author

@matt-bernhardt matt-bernhardt merged commit fea17c3 into master Jul 5, 2023
3 checks passed
@matt-bernhardt matt-bernhardt deleted the lm60 branch July 5, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants