Remove social media icons from News theme header #147
Conversation
** Why are these changes being introduced: * We are removing social media icons from across our website. In some cases, like the news site header, we are placing a link to a basic "Follow us" page that will allow us to more easily manage changes to which profiles the Libraries' maintain. * It turns out that when this area of the news site header is updated, some CSS changes are warranted. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/pw-66 ** How does this address that need: * This replaces the two links to X and Instagram in the News site header with a single link named "Follow us". * The spacing of elements in this list item are updated a bit, in order to introduce the pipe element and to ensure proper responsiveness. The overall list is no longer floated, but rendered as a flex element. ** Document any side effects to this change: * The elements in this list, as well as the site name which appears next to it, are now given the "nowrap" property, to prevent some awkward displays at some screen widths. * The News theme version is also incremented, following our practice of bumping this version to help with CSS cache busting. It should be noted that this stylesheet is not compiled by SCSS, but the cache busting is still a good thing regardless.
matt-bernhardt
changed the title
There was a problem hiding this comment.
Based on the weirdness with a deploy yesterday, can you closely follow https://github.com/MITLibraries/mitlib-wp-network/blob/master/docs/howto/promote-css-changes.md#the-procedure and confirm if it results in the appropriate CSS being served. I know this is not SCSS compiled so it isn't necessarily apples to apples with what we saw, but... 🤷🏻
|
Sure thing. I'm also going to merge and deploy this tomorrow at this point, and not at the end of the day today. :-) |
|
I just finished promoting this change up to Live, following the documented process. No problems, everything was as smooth as you could hope for. The latter portion of the procedure (in case the stylesheet changes don't immediately appear) were never needed. |
Ticket: https://mitlibraries.atlassian.net/browse/PW-66
Developer
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)