Move header customization to parent theme #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPrevost
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
This looks good to me and I believe I saw chatter that UX has signed off on it being functionally correct.
I'm curious if a future refactor might be to separate the html head from the site header. This is definitely fine for now but when I see a method like get_header() I'm not expecting the html head personally to be in that.
|
I agree about a future refactor that separates the contents of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer
Why changes are needed
Our child theme has a forked copy of the header template, which was meant to be a stripped down version of the parent theme's header that was used on some sites. Unfortunately, we've been poor at keeping this stripped-down header in sync with the full-content version. For example, our recent work changing the favicon was made to the full-content header in the parent theme, but not to the stripped-down version.
What this does
Rather than trying to identify all the changes that have been made and catching the slim header up, this re-factors the slim header entirely.
First, it moves the feature up from the child theme to the parent theme, so that only one of our themes has any header content at all.
Second, it re-structures the logic of the slim header to not be a separate file at all - but rather a conditional in the header template that skips some elements if the slim header is desired. This helps reduce the amount of repeated content that would need to be kept in sync in the future, and makes the code implementation of the feature match what is implied in the UI.
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)