Add location alert fields to homepage widget #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-bernhardt
force-pushed
the
pw-93
branch
8 times, most recently
from
7beeb18
to
5e7a14e
Compare
** Why are these changes being introduced: * There is an upcoming closure to the Hayden library, and we want to enable UXWS staff to be able to add alerts to the homepage for cases like this without asking for EngX to modify static templates. * After discussing the needed feature among themselves, UX has decided that a separate field for homepage alerts was preferrable, because that space frequently needs a single line of text that does not replicate the uses of the existing title and body fields for the current alert information. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/pw-93 ** How does this address that need: * First, we add a new field to the Location Attributes fieldset, named alert_frontpage. This field appears next to the other location alert fields (alert_title and alert_content), with help text advising that this new field should only have links added to it. * Second, we add a method to the widget class (which is provided by the hours plugin) to check for content in this new field. If content is found, it is included in the widget output below that location's entry. * The styling for this display is taken from the former styles for the Hayden renovation alert, which was statically added to this partial. * Because the parent theme's styles are changing, we bump the theme version. ** Document any side effects to this change: * This ticket is validating our choice to go with a monorepo for our WordPress application - as the changes being made might have spanned across several repositories in our previous infrastructure (one for the hours widget, one for the parent theme to change the styling, and potentially a third for the data model change - although that may have just been a configuration and not a code change before). * While the use of a class method and not a function in a tempalte is good, we are still mixing content and code because we have hard- coded location names, phone numbers, etc - as well as the post IDs for our actual locations. I'm choosing not to continue pulling on this thread, however.
JPrevost
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer
This change adds a field to the Location data model, along with display logic in the homepage hours widget, which combined allow the UX staff to manage alerts for the locations on the platform homepage.
This change does not affect the existing platform-wide alerts, nor the existing location-based alerts shown on the hours grid or the location homepages.
Relevant ticket(s):
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Additional context needed to review
There are links to the review app in the Jira ticket.
Code Reviewer
(not just this pull request message)