Update composer multidev-search-replace syntax #158
Conversation
** Why are these changes being introduced: * The search-replace syntax still uses the pantheonsite.io address for the live tier, not our actual domain ** Relevant ticket(s): n/a ** How does this address that need: * This changes the domain to use our actual libraries.mit.edu name ** Document any side effects to this change: * none
| @@ -61,7 +61,7 @@ public static function multidev_create_syntax( $event ): void { | |||
| */ | |||
| public static function multidev_search_replace_syntax( $event ): void { | |||
| $multidev = self::multidev_name( $event ); | |||
| $terminus_command = "terminus remote:wp mitlib-wp-network.$multidev -- search-replace live-mitlib-wp-network.pantheonsite.io $multidev-mitlib-wp-network.pantheonsite.io --url=live-mitlib-wp-network.pantheonsite.io --network"; | |||
| $terminus_command = "terminus remote:wp mitlib-wp-network.$multidev -- search-replace libraries.mit.edu $multidev-mitlib-wp-network.pantheonsite.io --url=libraries.mit.edu --network"; | |||
There was a problem hiding this comment.
Can you clarify what this is fixing? I'm assuming behavior has been weird since launch and we've needed to manually re-run the search-replace and this will possible make moving data between tiers less manual?
There was a problem hiding this comment.
This is the reminder about what search-replace command we should be running - it doesn't actually run the command.
The current output:
% composer multidev-search-replace-syntax pw-106
> MitComposerScripts::multidev_search_replace_syntax
terminus remote:wp mitlib-wp-network.pw-106 -- search-replace live-mitlib-wp-network.pantheonsite.io pw-106-mitlib-wp-network.pantheonsite.io --url=live-mitlib-wp-network.pantheonsite.io --networkThe problem is that this command won't do what we need now that we've got our domain in place. So every time we get this reminder, we need to remember to update the live-mitlib-wp-network.pantheonsite.io value.
This PR changes the output to be something that is accurate:
% composer multidev-search-replace-syntax pw-106
> MitComposerScripts::multidev_search_replace_syntax
terminus remote:wp mitlib-wp-network.pw-106 -- search-replace libraries.mit.edu pw-106-mitlib-wp-network.pantheonsite.io --url=libraries.mit.edu --networkThere was a problem hiding this comment.
Oh right! I totally forgot about that. Thanks for the reminder.
This updates the way a Composer command operates, making use of our actual domain name rather than the placeholder we used before we launched.
Developer
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)