Skip Sentry configuration in Lando environments #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPrevost
reviewed
Sep 17, 2024
** Why are these changes being introduced: We integrate with Sentry provided a given ENV value is defined in secrets.json, but this can result in local environments sending exceptions to Sentry - which be quite noisy and undesired. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/pw-106 ** How does this address that need: This adds an additional check around the Sentry configuration block, making sure that the PANTHEON_ENVIRONMENT variable is not sent to "lando" when integrating with Sentry. ** Document any side effects to this change: None
matt-bernhardt
force-pushed
the
pw-106
branch
from
e250f4e
to
042fe3a
Compare
JPrevost
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current Sentry integration with this app results in exceptions being sent to Sentry even when working locally, which causes confusion and counts against our message quota.
This change prevents local development exceptions from being sent to Sentry. Full details are in the commit message.
Developer
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/pw-106
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)