Skip to content

Commit

Permalink
Address code review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jazairi committed Jul 12, 2024
1 parent 549ea63 commit f33739c
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Accepted

We will need to authenticate users in TACOS to help manage access to the staff interface. The ideal authentication
approach would involve Omniauth integration, as IS&T recently implemented Okta, and
[a strategy already exists](https://github.com/omniauth/omniauth-okta) to authenticate in Okta using Omniauth.
[a strategy exists](https://github.com/omniauth/omniauth_openid_connect) to authenticate with OIDC using Omniauth.

## Options considered

Expand Down Expand Up @@ -93,7 +93,7 @@ third-party libraries. However, it is difficult to justify considering the addit

Ultimately, while all of these alternatives are appealing, there is a distinct advantage to choosing a gem that "just
works" and is widely adopted. Much like our
[decision to use CanCanCan for authorization](https://github.com/MITLibraries/tacos/blob/main/docs/architecture-decisions/0005-use-cancancan-for-authorization.md), I might not feel like Devise is the best authentication gem, but I have
[decision to use CanCanCan for authorization](https://github.com/MITLibraries/tacos/blob/main/docs/architecture-decisions/0006-use-cancancan-for-authorization.md), I might not feel like Devise is the best authentication gem, but I have
a difficult time convincing myself not to use it for this project.

## Consequences
Expand Down

0 comments on commit f33739c

Please sign in to comment.