Categorization dashboard #114
Conversation
Why are these changes being introduced: * Our config was allowing Terms and SearchEvents to be created and edited in Administrate which is not intended Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TCO-92 How does this address that need: * Restricts routes which is how Administrate determins which features to enable * Terms and SearchEvents cannot be created or edited in Administrate * This still allows admins to destroy a Term in case we determine it contains sensitive information. SearchEvents can only be destroyed by destroying the associated Term and relying on Rails to cleanup the relationship.
Why are these changes being introduced: * It will be convenient to have a mechansim in-app for authenticated users to look at our Categorizations prior to us building out custom reports/dashboards Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TCO-93 How does this address that need: * Adds a read-only administrate dashboard for Categorizations * Updates ability.rb to allow all authenticated users to view the dashboard Document any side effects to this change: This introduces minor changes to how Term and SearchEvents displays througout the Dashboards. Overall I think this is an improvement, but there may be edge cases where this change is not desired.
JPrevost
force-pushed
the
categorization_dashboard
branch
from
c36cecd
to
ddb7c7f
Compare
There was a problem hiding this comment.
This all looks okay to me. I've got one non-blocking request about the nav which non-admin users are shown, but if you'd rather not adopt that I'm happy to see this merge anyway.
My other comment, about field order for Categorizations, is me trying very hard not to micromanage an interface that I don't think will be used for long.
| can :manage, :detector__suggested_resource | ||
| can :manage, Detector::SuggestedResource | ||
|
|
||
| # Allow all authenticated users to view the Categorization index and show dashboards | ||
| can %w[index show], :categorization | ||
| can :read, Categorization |
There was a problem hiding this comment.
I've confirmed that non-admin users can see the Categorizations dashboard via this, but I worry that the nav needs to be adjusted as well. Right now there's no nav link that calls out Categorizations, the user is required to click a "Suggested Resources" link and then they find the Categorizations option as a surprise bonus?
Could we either change the existing single link to something broader in scope, or include a link for Categorizations specifically?
| # "Term ##{term.id}" | ||
| # end | ||
| def display_resource(term) | ||
| term.phrase |
There was a problem hiding this comment.
Good catch on this, makes the dashboard a lot more useful
| confidence | ||
| detector_version | ||
| term | ||
| ].freeze |
There was a problem hiding this comment.
I'm going to assume that we're going to be building a bespoke UI for this pretty soon, so am going to not suggest we customize this display at the moment. While the default alphabetical field order doesn't really make sense IMO, I don't think it's worth customizing at the moment if we're building a validation UI soon.
Why are these changes being introduced:
edited in Administrate which is not intended
users to look at our Categorizations prior to us building out custom
reports/dashboards
Relevant ticket(s):
How does this address that need:
to enable
contains sensitive information. SearchEvents can only be destroyed by
destroying the associated Term and relying on Rails to cleanup the
relationship.
dashboard
Document any side effects to this change:
This introduces minor changes to how Term and SearchEvents displays
througout the Dashboards. Overall I think this is an improvement, but
there may be edge cases where this change is not desired.
Developer
Ticket(s)
https://mitlibraries.atlassian.net/browse/TCO-###
Accessibility
all issues introduced by these changes have been resolved or opened
as new issues (link to those issues in the Pull Request details above)
Documentation
ENV
Stakeholders
Dependencies and migrations
YES | NO dependencies are updated
YES | NO migrations are included
Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing