Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds barnes gem to collect Ruby Language Metrics #122

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Oct 15, 2024

Why are these changes being introduced:

Relevant ticket(s):

How does this address that need:

  • adds barnes gem
  • configures puma per heroku docs to enable barnes
  • updates app.json to add the metrics collection to PR builds even though they probably won't do anything in our eco dynos

Document any side effects to this change:

None really, but the only other rails app we do this with is Bento. Other apps should likely get updated to collect this data if we don't see any side effects.

Developer

Accessibility

  • ANDI or Wave has been run in accordance to our guide and
    all issues introduced by these changes have been resolved or opened
    as new issues (link to those issues in the Pull Request details above)
  • There are no accessibility implications to this change

Documentation

  • Project documentation has been updated, and yard output previewed
  • No documentation changes are needed

ENV

  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.

Stakeholders

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies and migrations

YES dependencies are updated

NO migrations are included

Reviewer

Code

  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.

Documentation

  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.

Testing

  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@mitlib mitlib temporarily deployed to tacos-api-pipeline-pr-122 October 15, 2024 20:44 Inactive
@matt-bernhardt matt-bernhardt self-assigned this Oct 17, 2024
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's try adding this and see how we can use this level of metrics. I see the two charts in the Bento app, but obviously don't have anything to look at in TACOS yet since these aren't available in Eco dynos.

:shipit:

Why are these changes being introduced:

* This adds a few additional useful metrics in our heroku dashboard
  for stage/prod level apps (it doesn't work in eco dynos so pr
  builds will not collect this data)
* see also:
  https://devcenter.heroku.com/articles/language-runtime-metrics-ruby

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/TCO-78

How does this address that need:

* adds barnes gem
* configures puma per heroku docs to enable barnes
* updates app.json to add the metrics collection to PR builds even
  though they probably won't do anything in our eco dynos

Document any side effects to this change:

None really, but the only other rails app we do this with is Bento.
Other apps should likely get updated to collect this data if we don't
see any side effects.
@JPrevost JPrevost temporarily deployed to tacos-api-pipeline-pr-122 October 17, 2024 20:14 Inactive
@JPrevost JPrevost merged commit 817191e into main Oct 17, 2024
3 checks passed
@JPrevost JPrevost deleted the tco-78-runtime-metrics branch October 17, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants