Adds data lookup for detected standard identifiers #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why are these changes being introduced: * The ability to provide additional details about what TACOS can detect will allow consuming systems to act on that information. That may mean simply displaying it, or it may mean modifying queries to other systems in more nuanced ways than the original raw search from the user may have led to Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ENGX-244 How does this address that need: * This brings the Fact lookup models over from TIMDEX UI and modifies them slightly to be more useful to this application. * A details section has been added under standard_identifiers in graphql that will trigger lookups if identifiers have been detected. * Only lookups that have matches are run, and only if a user has requested details be provided by requesting fields within the details block Document any side effects to this change: dotenv-rails was introduced as a dependency to simplify the test environment configuration. Any missing configuration documented in the README will result in exceptions.
JPrevost
force-pushed
the
engx244-lookups
branch
from
5f40efd
to
9364206
Compare
jazairi
approved these changes
Nov 20, 2023
| end | ||
|
|
||
| def link_resolver_url(metadata) | ||
| "#{ENV.fetch('LINKRESOLVER_BASEURL')}&rft.atitle=#{metadata[:title]}&rft.date=#{metadata[:year]}&rft.genre=#{metadata[:genre]}&rft.jtitle=#{metadata[:journal_name]}&rft_id=info:doi/#{metadata[:doi]}" |
There was a problem hiding this comment.
This made me nervous when I did it in Bento, and it makes me nervous here. 🙂 I do think the benefits outweigh the risks, though. The only potential downside is having broken links that we don't know are broken, and the risk of that feels relatively low since it's just OpenURL.
There was a problem hiding this comment.
Is it the manual construction of OpenURL in general that is causing nervousness or something more specific about how it is being constructed. Trusting Alma LinkResolver to be useful is indeed nervous making.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
dotenv-rails was introduced as a dependency to simplify the test environment configuration.
Any missing configuration documented in the
README will result in exceptions.