Add rack-cors and configuration #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: * The application needs to accept communications from other domains in order to do its job. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/engx-266 ** How does this address that need: * This adds the rack-cors gem, with the recommended default config file, to enable the application to receive communication from our various search applications. * A new required ENV is defined, to give control over which systems can connect via CORS. By default, no external connections are allowed. ** Document any side effects to this change: * None
matt-bernhardt
force-pushed
the
engx-266-cors
branch
from
6843086
to
df6e1e9
Compare
JPrevost
approved these changes
May 20, 2024
README.md
Outdated
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| `LINKRESOLVER_BASEURL`: base url for our link resolver. `https://mit.primo.exlibrisgroup.com/discovery/openurl?institution=01MIT_INST&rfr_id=info:sid/mit.tacos.api&vid=01MIT_INST:MIT` is probably the best value unless you are doing something interesting. | |||
|
|
|||
| `ORIGINS`: comma-separated list of domains allowed to connect to (and thus query or contribute to) the application. If not defined, no external connections will be permitted. | |||
There was a problem hiding this comment.
Maybe add a note that non-standard ports also need to be included (i.e. localhost will not work when running on localhost:5000, etc)
Update env description based on code review feedback
|
Good call - I had to work out the port number thing myself, so that's probably good to have in the readme. I've pushed a commit to update the description there. |
JPrevost
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the rack-cors gem, with the recommended default config file,
to enable the application to receive communication from our various
search applications.
To confirm that this is solving the CORS problem, I've been connecting to the Rails console in the review app, doing searches in the related Bento PR build, and confirming that I can see them appearing via the console.
Developer
Tickets
Requires database migrations?
NO
Includes new or updated dependencies?
YES
Code Reviewer
(not just this pull request message)