Add ADR to select an authorization gem #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: We will need authorization in TACOS for the staff UI, which first requires us to choose an authorization gem. Relevant ticket(s): * [TCO-30](https://mitlibraries.atlassian.net/browse/TCO-30) How this addresses that need: This adds an ADR to select an authorization gem from among CanCanCan, Pundit, and Action Policy. Side effects of this change: The decision we make will affect how we implement authorization.
JPrevost
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
I support the decision to use CanCanCan. Our needs are likely to be simple for the foreseeable future and the additional features/speed of the alternatives do not outweigh the additional complexity/repetitiveness/boilerplate they require. If our needs change over time, I agree with the assessment here that we could migrate to another option when we better understand those needs.
matt-bernhardt
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We will need authorization in TACOS for the staff UI, which first requires us to choose an authorization gem.
Relevant ticket(s):
How this addresses that need:
This adds an ADR to select an authorization gem from among CanCanCan, Pundit, and Action Policy.
Side effects of this change:
The decision we make will affect how we implement authorization.