Updates PMID detection regex #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazairi
approved these changes
Jul 11, 2024
Why are these changes being introduced: * The regex was missing PMIDs with no space between the `PMID:` and the indentifier, such as `PMID:35648703` Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TCO-42 How does this address that need: * Updates regex to allow, but not require, a single whitespace character between `pmid:` and the indentifier
JPrevost
force-pushed
the
tco42-pmid-with-no-spaces
branch
from
3215744
to
d07a583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: PMID detection may be entirely silly based on our current bento derived search corpus, but I'd like to keep it in for now as once we expand beyond Bento we may find people search differently.
Why are these changes being introduced:
PMID:and the indentifier, such asPMID:35648703Relevant ticket(s):
How does this address that need:
pmid:and the indentifier