Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Searchevent and term #6

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Adds Searchevent and term #6

merged 3 commits into from
Oct 23, 2023

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Oct 19, 2023

Why are these changes being introduced:

  • this implements the first two models and will enable the storage of
    the data necessary to get started with this application

Relevant ticket(s):

How does this address that need:

  • Rails

Document any side effects to this change:

  • some of our typical developer gems, rubocop and annotate were added
  • rubocop was used to autoformat everything in the /app and /test
    directories
  • adds our standard CI setup
  • adds dependabot weekly checks

- reorder and change quotes mostly
Why are these changes being introduced:

* this implements the first two models and will enable the storage of
  the data necessary to get started with this application

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/ENGX-232
https://mitlibraries.atlassian.net/browse/ENGX-233

How does this address that need:

* Rails

Document any side effects to this change:

- some of our typical developer gems, rubocop and annotate were added
- rubocop was used to autoformat everything in the `/app` and `test`
  directories
@jazairi jazairi self-assigned this Oct 23, 2023
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with my understanding of the most recent version of the class diagram. I suspect we'll want an initialize method on the Term class, but we can add that later if it makes sense when we start to do more with these models.

Thanks for doing all the Rails and CI setup, too; in retrospect, that probably should've been a separate ticket!

@JPrevost
Copy link
Member Author

@jazairi yeah I hadn't decided yet where the logic would live to sort find_or_create a new term to add a new SearchEvent. That could be what you were referring to with the initialize method? Either way, I agree we can add it when we need it (wherever it ends up making sense)

@JPrevost JPrevost merged commit ae113b7 into main Oct 23, 2023
2 checks passed
@JPrevost JPrevost deleted the ENGX-233-searchevent-and-term branch October 23, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants