Ensure theses are not publishable without an accession number #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazairi
force-pushed
the
etd-596-accession-publication-check
branch
from
b01905a
to
4490a65
Compare
jazairi
force-pushed
the
etd-596-accession-publication-check
branch
from
fa8f877
to
1a63f24
Compare
…sion number Why these changes are being introduced: Because we want the accession number to be used in the preservation workflow, we do not want a thesis without an accession number to be published. Relevant ticket(s): https://mitlibraries.atlassian.net/browse/ETD-596 How this addresses that need: This adds an `accession_number` convenience method to the Thesis model that can look up an accession based on a thesis' degree period. This method is included in the publication checks. The thesis processing form now shows whether it can find an accession number. If no accession number exists, the form will render a hint that prompts the user to create an accession number for the given degree period. Side effects of this change: * A future state of this application is for the Thesis model to belong to the Degree Period model. For now, there is no direct assocation, so we are using ActiveRecord lookups based on the thesis' graduation year and graduation month. * Some fixtures have been added to allow tests related to publication status to pass. (Certain thesis fixtures had no degree periods or accession numbers, they could not be put into publication review.) * The `new` action on the Archivematica Accessions dashboard has been overwritten to prefill the degree period ID from params.
jazairi
force-pushed
the
etd-596-accession-publication-check
branch
from
1a63f24
to
c4a879a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
Because we want the accession number to be used in the preservation workflow, we do not want a thesis without an accession number to be published.
Relevant ticket(s):
https://mitlibraries.atlassian.net/browse/ETD-596
How this addresses that need:
This adds an
accession_numberconvenience method to the Thesis model that can look up an accession based on a thesis' degree period. This method is included in the publication checks.The thesis processing form now shows whether it can find an accession number. If no accession number exists, the form will render a hint that prompts the user to create an accession number for the given degree period.
Side effects of this change:
newaction on the Archivematica Accessions dashboard has been overwritten to prefill the degree period ID from params.Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO