Disable transfers when in maintenance mode #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazairi
force-pushed
the
etd-649-maintenance-mode
branch
from
6f60cec
to
1005e23
Compare
JPrevost
reviewed
Oct 24, 2023
| @@ -0,0 +1,9 @@ | |||
| <div class="well maintenance-message"> | |||
| <% if ENV.fetch('MAINTENANCE_MESSAGE_TRANSFER', false) %> | |||
| <h4 class="hd-5"><%= ENV['MAINTENANCE_MESSAGE_TRANSFER'].to_s %></h4> | |||
There was a problem hiding this comment.
We should be able to trust this input and making this .html_safe instead of .to_s would allow more flexibility in the custom messages.
app/views/transfer/new.html.erb
Outdated
|
|
||
| <% if Flipflop.enabled?(:maintenance_mode) %> | ||
| <script type="text/javascript"> | ||
| $(':input').prop('disabled', true); |
There was a problem hiding this comment.
Adding
$('#new_transfer').hide();
in addition to disabling feels like it would be slightly less confusing to someone that stumbled across this. Thoughts?
There was a problem hiding this comment.
Yeah, that's a good suggestion. I don't see any downside to hiding the form as well.
jazairi
force-pushed
the
etd-649-maintenance-mode
branch
from
8cbb438
to
937f46f
Compare
Why these changes are being introduced: In anticipation of migrating to new AWS infrastructure, we will need to pause file uploads for a bit. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/ETD-649 How this addresses that need: This adds a maintenance mode feature, toggled via the flipflop gem, that disables and hides the thesis transfer form and changes the welcome message on `transfer/new` to explain what is happening. A custom message can be configured to provide additional details. Side effects of this change: * It is still technically possible to post a new transfer if one were to bypass the form. I find it unlikely that transfer submitters would try to hack this, but if it's a concern, we could try a different approach. * Currently, maintenance mode only disables thesis transfers. I chose to give the feature a more generalized name in case we want to use it to disable additional functionality in the future.
jazairi
force-pushed
the
etd-649-maintenance-mode
branch
from
937f46f
to
27b96b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
In anticipation of migrating to new AWS infrastructure, we will need to pause file uploads for a bit.
Relevant ticket(s):
How this addresses that need:
This adds a maintenance mode feature, toggled via the flipflop gem, that disables the thesis transfer form and changes the welcome message on
transfer/newto explain what is happening. A custom message can be configured to provide additional details.Side effects of this change:
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
YES