Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rails 2.23.1 → 2.24.1 (minor) #1294

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 26, 2024

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.23.1 → 2.24.1) · Repo · Changelog

Release Notes

2.24.1

Bug fixes

  • #1244: Fix a false positive for Rails/ActionControllerFlashBeforeRender when returning redirect_to. (@earlopain)
  • #1255: Fix an error for Rails/UniqBeforePluck with EnforcedStyle: aggressive when no receiver. (@earlopain)
  • #1247: Fix an error for Rails/UnusedIgnoredColumns when without tables in db/schema.rb. (@koic)
  • #1253: Fix an error for Rails/WhereMissing with leading where without receiver. (@earlopain)
  • #1254: Fix an error for Rails/ExpandedDateRange when passing an argument only to the first method call for weeks. (@earlopain)
  • #1256: Fix an error for Rails/ActiveSupportOnLoad when calling without arguments. (@earlopain)
  • #1230: Fix a false positive for Rails/SaveBang if persisted? is checked on parenthesised expression. (@earlopain)
  • #1200: Make Rails/TimeZone aware of safe navigation. (@earlopain)

Changes

  • #1257: Add Rails 7.1 load hooks and active_record_sqlite3adapter to Rails/ActiveSupportOnLoad. (@earlopain)

2.24.0

New features

  • #1245: Support Prism as a Ruby parser (experimental). (@koic)

Bug fixes

  • #1234: Fix an incorrect autocorrect for Rails/FindBy when using multi-line leading dot method calls. (@ymap)
  • #1241: Fix an error for Rails/WhereExists with EnforcedStyle: where and implicit receivers. (@earlopain)

Changes

  • #1229: Make Rails/EnvironmentVariableAccess aware of initializers. (@markokajzer)
  • #1231: Remove object_id from Rails/DangerousColumnNames targets. (@r7kamura)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 44 commits:

✳️ rubocop (1.60.2 → 1.62.1) · Repo · Changelog

Release Notes

1.62.1

Bug fixes

  • #12761: Fix a false positive for Style/HashEachMethods when the key block argument of Enumerable#each method is unused after chunk. (@koic)
  • #12768: Fix a false positive for Style/NilComparison without receiver and EnforcedStyle: comparison. (@earlopain)
  • #12752: Fix an error for Gemspec/RequiredRubyVersion when the file is empty. (@earlopain)
  • #12770: Fix an error for Lint/RedundantWithIndex when the method has no receiver. (@earlopain)
  • #12775: Fix an error for Lint/UselessTimes when no block is present. (@earlopain)
  • #12772: Fix an error for Style/ClassVars when calling class_variable_set without arguments. (@earlopain)
  • #12773: Fix an error for Style/For with EnforcedStyle: for when no receiver. (@earlopain)
  • #12765: Fix an error for Layout/MultilineMethodCallIndentation with safe navigation and assignment method. (@earlopain)
  • #12703: Fix an error for Lint/MixedCaseRange with invalid byte sequence in UTF-8. (@earlopain)
  • #12755: Fix an exception for RedundantCurrentDirectoryInPath in case of require_relative without arguments. (@viralpraxis)
  • #12710: Fix a false negative for Layout/EmptyLineAfterMagicComment when the file is comments only. (@earlopain)
  • #12758: Fix false positives for Layout/RedundantLineBreak when using && or || after a backslash newline. (@koic)
  • #12763: Fix an infinite loop for Style/MultilineMethodSignature when there is a newline directly after the def keyword. (@earlopain)
  • #12774: Fix an infinite loop for Style/RaiseArgs with EnforcedStyle: compact when passing more than 2 arguments to raise. (@earlopain)
  • #12663: Fix Lint/Syntax getting disabled by rubocop:disable Lint/Syntax. (@earlopain)
  • #12756: Only parse target Ruby from gemspec if array elements are strings. (@davidrunger)

Changes

1.62.0

Note: This is the first RuboCop release that features (experimental) support for using Prism instead of the parser gem. Check out the docs for more details.

See also this article for additional context.

New features

  • #12600: Support Prism as a Ruby parser (experimental). (@koic)
  • #12725: Support TargetRubyVersion 3.4 (experimental). (@koic)

Bug fixes

  • #12746: Fix a false positive for Lint/ToEnumArguments when enumerator is created for another method in no arguments method definition. (@koic)
  • #12726: Fix a false positive for Style/RedundantLineContinuation when using line concatenation and calling a method with keyword arguments without parentheses. (@koic)
  • #12738: Fix an error for Style/Encoding when magic encoding with mixed case present. (@koic)
  • #12732: Fix error determining target Ruby when gemspec required_ruby_version is read from another file. (@davidrunger)
  • #12736: Fix invalid autocorrect in Layout/SpaceInsideHashLiteralBraces. (@bquorning)
  • #12667: Don't load excluded configuration. (@jonas054)

1.61.0

New features

  • #12682: Add --editor-mode CLI option. (@koic)
  • #12657: Support AutoCorrect: contextual option for LSP. (@koic)
  • #12273: Make OffenseCountFormatter display autocorrection information. (@koic)
  • #12679: Publish RuboCop::LSP.enable API to enable LSP mode. (@koic)
  • #12699: Support searching for .rubocop.yml and rubocop/config.yml in compliance with dot-config. (@koic)

Bug fixes

  • #12720: Fix a false positive for Style/ArgumentsForwarding when using block arg forwarding to within block with Ruby 3.3.0. (@koic)
  • #12714: Fix an error for Gemspec/RequiredRubyVersion when required_ruby_version is specified with Gem::Requirement.new and is higher than TargetRubyVersion. (@koic)
  • #12690: Fix an error for Style/CaseLikeIf when using == with literal and using ternary operator. (@koic)
  • #12668: Fix an incorrect autocorrect for Lint/EmptyConditionalBody when missing if body with conditional else body. (@koic)
  • #12683: Fix an incorrect autocorrect for Style/MapCompactWithConditionalBlock when using guard clause with next implicitly nil. (@koic)
  • #12693: Fix an incorrect autocorrect for Style/ObjectThen when using yield_self without receiver. (@koic)
  • #12646: Fix --auto-gen-config bug for Layout/SpaceBeforeBlockBraces. (@jonas054)
  • #12717: Fix regexp for inline disable comments in Style/CommentedKeyword. (@jonas054)
  • #12695: Fix bug in Include from inherited file in a parent directory. (@jonas054)
  • #12656: Fix an error for Layout/RedundantLineBreak when using index access call chained on multiline hash literal. (@koic)
  • #12691: Fix an error for Style/MultilineTernaryOperator when nesting multiline ternary operators. (@koic)
  • #12707: Fix false negative for Style/RedundantAssignment when using pattern matching. (@koic)
  • #12674: Fix false negatives for Style/RedundantReturn when using pattern matching. (@koic)
  • #12673: Fix false negatives for Lint/RedundantSafeNavigation when using safe navigation operator for literal receiver. (@koic)
  • #12719: Fix false negatives for Style/ArgumentsForwarding when using forwardable block arguments with Ruby 3.2+. (@koic)
  • #12687: Fix a false positive for Lint/Void when each block with conditional expressions that has multiple statements. (@koic)
  • #12649: Fix false positives for Style/InverseMethods when using relational comparison operator with safe navigation. (@koic)
  • #12711: Handle implicit receivers in Style/InvertibleUnlessCondition. (@sambostock)
  • #12648: Fix numblock regressions in omit_parentheses Style/MethodCallWithArgsParentheses. (@gsamokovarov)

Changes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ i18n (indirect, 1.14.1 → 1.14.4) · Repo · Changelog

Release Notes

1.14.4

What's Changed

Note: the racc dependency will be coming back in Version 2.

  • undo strict racc dependency on this branch by @radar in #687

Full Changelog: v1.14.3...v1.14.4

1.14.3

What's Changed

  • Pass options to along to exists? super calls by @radar in #671
  • Improve TOKENIZER by 23% by @kbrock in #668
  • Regex part deux - INTERPOLATION_SYNTAX by @kbrock in #669
  • Raise when translated entry contains interpolations for reserved keywords and no substitutions provided by @fatkodima in #678
  • Implement Fallbacks#inspect and Fallbacks#empty? by @fatkodima in #683

Upkeep

New Contributors

Full Changelog: v1.14.1...v1.14.3

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 28 commits:

↗️ minitest (indirect, 5.22.2 → 5.22.3) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 5 commits:

↗️ rack (indirect, 2.2.8.1 → 2.2.9) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ rubocop-ast (indirect, 1.30.0 → 1.31.2) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 24 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Mar 26, 2024
@mitlib mitlib temporarily deployed to thesis-submit-pr-1294 March 26, 2024 04:46 Inactive
@coveralls
Copy link

Coverage Status

coverage: 98.313%. remained the same
when pulling ca685ff on depfu/update/rubocop-rails-2.24.1
into 81d1964 on main.

Copy link
Contributor Author

depfu bot commented Apr 3, 2024

Closing because this update has already been applied

@depfu depfu bot closed this Apr 3, 2024
@depfu depfu bot deleted the depfu/update/rubocop-rails-2.24.1 branch April 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants