Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1297

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Update dependencies #1297

merged 1 commit into from
Apr 3, 2024

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Apr 3, 2024

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

YES | NO

Includes new or updated dependencies?

YES | NO

@mitlib mitlib temporarily deployed to thesis-submit-pr-1297 April 3, 2024 19:13 Inactive
@jazairi jazairi merged commit ca4f371 into main Apr 3, 2024
3 checks passed
@coveralls
Copy link

Coverage Status

coverage: 98.313%. remained the same
when pulling b4e4ecd on update-dependencies
into e34910d on main.

@jazairi jazairi deleted the update-dependencies branch June 28, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants