-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow manually republishing thesis in Pending publication
status
#1309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't confirmed the changes, but I have a high level of confidence that this will work. Before you merge this, can you update the docs for this task to mention the Pending publication
status?
We had a small batch of theses not end up in the SQS queue as expected. This small change should allow us to republish each one (one at a time) to see if we can better track down what happened (i.e. if one errors, we can assume something about it is causing this problem. If they all succeed, it was something external to an individual thesis). This does not solve the root problem, it just allows us to more efficiently retry publication on individual theses when this app thinks they are in a publishing queue but they are not.
@jazairi I'm merging without review as the only change beyond your initial review was documentation in order to move this into production asap. Please do review/comment if the docs are not what you feel would be useful and we can update them in a separate PR. |
Looks good to me! Thanks for noting the reason for including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting post-merge approval.
We had a small batch of theses not end up in the SQS queue as expected.
This small change should allow us to republish each one (one at a time) to see if we can better track down what happened (i.e. if one errors, we can assume something about it is causing this problem. If they all succeed, it was something external to an individual thesis).
This does not solve the root problem, it just allows us to more efficiently retry publication on individual theses when this app thinks they are in a publishing queue but they are not.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO