Updates all AWS gems and skips some assertions and tests #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our tests have some syntax errors in some of the mocks. We will fix them, but for now we are skipping failures and pushing the updated gems to allow us to read the production SQS queues which is not currently possible due to a change introduced somewhere in SQS or the associated gems.
All failing tests in the DspacePublicationResultsJob test are related to the stubbed message that involves a bad checksum. On further investigation, this message has the same `message_id` as another message. [The SQS API docs](https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_Message.html) specify that the `MessageId` property must be unique. It's possible that this was always the case, but it was only enforced in more recent versions of `aws-sdk-sqs`, which would explain why these tests only started erroring when we tried to upgrade the gem.
JPrevost
commented
Jul 9, 2024
| @@ -26,7 +26,7 @@ def setup | |||
| 'SubmissionSource' => { string_value: 'ETD', data_type: 'String' } } }, | |||
|
|
|||
| # success but thesis no longer has files locally | |||
| { message_id: 'id1a', receipt_handle: 'handle1a', | |||
| { message_id: 'id1b', receipt_handle: 'handle1a', | |||
There was a problem hiding this comment.
Yeah, I felt pretty silly when I caught that. 😅 (Both that we had duplicate IDs, and that we chose such a weird, brittle naming pattern!)
jazairi
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
See the commit I pushed for a possible solution to the failing test issue. I'm approving this with or without that commit, as I think it's safe to skip those tests based on my current understanding.
Thank you for taking the time to solve this and upgrade these long-outdated gems!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests have some syntax errors in some of the mocks. We will fix them, but for now we are skipping failures and pushing the updated gems to allow us to read the production SQS queues which is not currently possible due to a change introduced somewhere in SQS or the associated gems.
Requires database migrations?
NO
Includes new or updated dependencies?
YES