Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates all AWS gems and skips some assertions and tests #1329

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Updates all AWS gems and skips some assertions and tests #1329

merged 2 commits into from
Jul 10, 2024

Commits on Jul 9, 2024

  1. Updates all AWS gems and skips some assertions and tests 

    Our tests have some syntax errors in some of the mocks. We will fix them, but for now we are skipping failures and pushing the updated gems to allow us to read the production SQS queues which is not currently possible due to a change introduced somewhere in SQS or the associated gems.
    @JPrevost
    JPrevost committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    dfa3f9f View commit details
    Browse the repository at this point in the history

  2. Unskip publication results job tests and make message IDs unique 

    All failing tests in the DspacePublicationResultsJob test are
related to the stubbed message that involves a bad checksum. On
further investigation, this message has the same `message_id` as
another message.

[The SQS API docs](https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_Message.html)
specify that the `MessageId` property must be unique. It's possible
that this was always the case, but it was only enforced in more
recent versions of `aws-sdk-sqs`, which would explain why these
tests only started erroring when we tried to upgrade the gem.
    @jazairi
    jazairi committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b1c46b5 View commit details
    Browse the repository at this point in the history