Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update rubocop-rails 2.25.1 → 2.26.0 (minor) #1347

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Aug 25, 2024


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.25.1 → 2.26.0) · Repo · Changelog

Release Notes

2.26.0

New features

Bug fixes

  • #1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. (@earlopain)
  • #1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. (@earlopain)
  • #1337: Fix an error for Rails/Validation when passing no arguments. (@earlopain)
  • #1330: Fix an error for Rails/WhereNot when using placeholder without second argument. (@earlopain)
  • #1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. (@tldn0718)
  • #1313: Fix false positives for Rails/CompactBlank when using collection.reject!. (@koic)
  • #1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. (@earlopain)
  • #1306: Make Rails/PluralizationGrammar aware of byte methods. (@earlopain)
  • #1302: Allow params receiver by default for Style/CollectionMethods. (@koic)
  • #1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). (@earlopain)

Changes

  • #1308: Change Rails/CompactBlank to handle select(&:present?). (@fatkodima)
  • #1303: Change Rails/IgnoredSkipActionFilterOption to handle multiple callbacks. (@fatkodima)
  • #1199: Make Rails/WhereEquals aware of where.not(...). (@earlopain)
  • #1003: Change Rails/RootPathnameMethods to detect offenses on Dir.[]. (@r7kamura)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 47 commits:

↗️ minitest (indirect, 5.25.0 → 5.25.1) · Repo · Changelog

Release Notes

5.25.1 (from changelog)

  • 2 bug fixes:

    • Fix incompatibility caused by minitest-hooks & rails invading minitest internals.

    • Revert change from =~ to match? to allow for nil if $TERM undefined.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ parallel (indirect, 1.26.2 → 1.26.3) · Repo

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ rexml (indirect, 3.3.5 → 3.3.6) · Repo · Changelog

Security Advisories 🚨

🚨 REXML denial of service vulnerability

Impact

The REXML gem before 3.3.6 has a DoS vulnerability when it parses an XML that has many deep elements that have same local name attributes.

If you need to parse untrusted XMLs with tree parser API like REXML::Document.new, you may be impacted to this vulnerability. If you use other parser APIs such as stream parser API and SAX2 parser API, this vulnerability is not affected.

Patches

The REXML gem 3.3.6 or later include the patch to fix the vulnerability.

Workarounds

Don't parse untrusted XMLs with tree parser API.

Release Notes

3.3.6

Improvements

  • Removed duplicated entity expansions for performance.

    • GH-194
    • Patch by Viktor Ivarsson.
  • Improved namespace conflicted attribute check performance. It was
    too slow for deep elements.

    • Reported by l33thaxor.

Fixes

  • Fixed a bug that default entity expansions are counted for
    security check. Default entity expansions should not be counted
    because they don't have a security risk.

  • Fixed a parser bug that parameter entity references in internal
    subsets are expanded. It's not allowed in the XML specification.

  • Fixed a stream parser bug that user-defined entity references in
    text aren't expanded.

Thanks

  • Viktor Ivarsson

  • NAITOH Jun

  • l33thaxor

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 15 commits:

↗️ rubocop-ast (indirect, 1.32.0 → 1.32.1) · Repo · Changelog

Release Notes

1.32.1 (from changelog)

Changes

  • #309: Mark RuboCop::AST::EnsureNode as being in a void context. (@earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 6 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Aug 25, 2024
@mitlib mitlib temporarily deployed to thesis-submit-pr-1347 August 25, 2024 09:48 Inactive
@coveralls
Copy link

Coverage Status

coverage: 98.313%. remained the same
when pulling a0bc5fd on depfu/update/rubocop-rails-2.26.0
into b2eab6b on main.

Copy link
Contributor Author

depfu bot commented Sep 8, 2024

Closed in favor of #1351.

@depfu depfu bot closed this Sep 8, 2024
@depfu depfu bot deleted the depfu/update/rubocop-rails-2.26.0 branch September 8, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants