Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: added all get all api and post request #23

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Feat: added all get all api and post request #23

merged 9 commits into from
Oct 9, 2024

Conversation

byhlel
Copy link
Contributor

@byhlel byhlel commented Sep 24, 2024 •
edited
Loading

Resolves #21, Resolves #18, Resolves #15
Resolves #22 , Resolves #16 , Resolves #19
Quite direct implementation!

@byhlel
feat: api route to return all experiences
b7beecf 
Added another example to check that result is returned as list

Resolves Implement API route to return all "Experiences" MLH-Fellowship#21
@byhlel
feat: api route to return all educations
a4c65a1 
Resolves Implement API route to return all "Educations" MLH-Fellowship#18
@byhlel
feat: api route to return all skills
fe81465 
Resolves Implement API route to return all "Skills" MLH-Fellowship#15
@byhlel
feat: Implement API route to add new "Skills"
29ea6b4 
Resolves Implement API route to add new "Skills" MLH-Fellowship#16
@byhlel
feat: Implement API route to add new "Education"
c66f2b0 
Resolves Implement API route to add new "Education" MLH-Fellowship#19
@byhlel
feat: Implement API route to add new "Experience"
60971ab 
Resolves Implement API route to add new "Experience" MLH-Fellowship#22
@byhlel
Copy link
Contributor Author

byhlel commented Sep 24, 2024

Edited the pytest to make more sense to the json returned object.

Now testsuite passes for present cases!

@byhlel byhlel changed the title Feat: added all get all api requests Feat: added all get all api and post request Sep 24, 2024
citruscai
citruscai approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@citruscai citruscai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! (edit: oops i thought other fellows were allowed to approve pull requests! sorry)

@vantage-ola vantage-ola mentioned this pull request Oct 4, 2024
Merged
@Shopiley
Copy link
Contributor

Shopiley commented Oct 6, 2024

Hi @byhlel, I think you need to tag one of the pod leaders/maintainers to review this so it can be merged.

@byhlel
Copy link
Contributor Author

byhlel commented Oct 7, 2024

@yashika51 could you accept this PR? Thanks, it will fix CI/CD for future uses as well.

@yashika51
Copy link
Collaborator

@yashika51 could you accept this PR? Thanks, it will fix CI/CD for future uses as well.

Can you fix the lint issue and then go ahead and merge it

@byhlel
Copy link
Contributor Author

byhlel commented Oct 8, 2024

Following the PR I had to deal with merge conflicts therefore I believe you need to approve again @yashika51 .
Thank you

@yashika51
Copy link
Collaborator

Following the PR I had to deal with merge conflicts therefore I believe you need to approve again @yashika51 . Thank you

would you like to include the fix to the linting issue in this PR as well?

@byhlel
Copy link
Contributor Author

byhlel commented Oct 9, 2024

@yashika51 Should be good now

@vantage-ola vantage-ola mentioned this pull request Oct 9, 2024
Merged
@yashika51 yashika51 merged commit 3aaf225 into MLH-Fellowship:main Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citruscai citruscai citruscai approved these changes

@yashika51 yashika51 yashika51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@byhlel @Shopiley @yashika51 @citruscai