Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ability to handle user information for resume #24

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

vantage-ola
Copy link
Member

@vantage-ola vantage-ola commented Sep 30, 2024

This PR aims to store the following information of the user, with routes for adding(POST) and updating(PUT) it.

  • Name
  • Phone Number (enforce international country code)
  • Email Address

resolves #1

@vantage-ola vantage-ola marked this pull request as ready for review October 1, 2024 14:14
@vantage-ola
Copy link
Member Author

vantage-ola commented Oct 2, 2024

pr aims to resolve #1

@vantage-ola
Copy link
Member Author

@yashika51 would love you to do a review, thanks 🙏

@yashika51
Copy link
Collaborator

@yashika51 would love you to do a review, thanks 🙏

Hi! Can you address the tests failing before we merge?

@vantage-ola
Copy link
Member Author

vantage-ola commented Oct 4, 2024

@yashika51 If you inspect the tests, i wrote a test suite that passed. the remaining tests(that are failing) and fixes has been resolved by #23

@yashika51 yashika51 merged commit 5653cfa into MLH-Fellowship:main Oct 4, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to handle user information for resume
2 participants