mlton-script: OpenBSD link-opt for no xonly text #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `-target-link-opt` for OpenBSD that disables "xonly" text.
OpenBSD's linker, by default, makes a program's text segment
executable-only ("xonly"): that is, executable but not readable.
However, MLton needs to be able to read the text segment when
mapping return addresses to stack frame indices, possibly among
other things. This causes programs compiled with MLton's native
code generator to fault and die with `SIGSEGV`.
However, the default "xonly" behavior can be disabled with a
linker option (`--no-execute-only`), so we can turn it off with
a `-target-link-opt` specific to OpenBSD in `mlton-script`.
Binaries built in this configuration run as expected.
Fixes MLton#538
Signed-off-by: Dan Cross <cross@gajendra.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
-target-link-optfor OpenBSD that disables "xonly" text.OpenBSD's linker, by default, makes a program's text segment executable-only ("xonly"): that is, executable but not readable. However, MLton needs to be able to read the text segment when mapping return addresses to stack frame indices, possibly among other things. This causes programs compiled with MLton's native code generator to fault and die with
SIGSEGV.However, the default "xonly" behavior can be disabled with a linker option (
--no-execute-only), so we can turn it off with a-target-link-optspecific to OpenBSD inmlton-script. Binaries built in this configuration run as expected.Fixes #538