[Feat] #276 - 디스코드 회원가입 알림에 누적회원수 추가 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-sky
approved these changes
May 29, 2024
| eventPublisher.publishEvent(SignUpEvent.of( | ||
| totalUsers, |
There was a problem hiding this comment.
p4;
필드명을 totalUsers보다 totalUserCount로 하는게 더 바람직해 보이는데 어떻게 생각하시나요?
아래 부분들도 공통적입니다
There was a problem hiding this comment.
필드명이 긴 것 같아서 totalUsers로 했었는데 Count를 붙이는게 더 직관적인것 같네요 ! 바로 반영 완료했습니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀PullRequest🚀
📟 관련 이슈
💻 작업 내용
📝 리뷰 노트