Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #284 - 소셜 API 버그 수정 #285

Merged
merged 2 commits into from
Jun 1, 2024
Merged

[Fix] #284 - 소셜 API 버그 수정 #285

merged 2 commits into from
Jun 1, 2024

Conversation

0lynny
Copy link
Member

@0lynny 0lynny commented Jun 1, 2024

🚀PullRequest🚀

📟 관련 이슈

💻 작업 내용

  • 소셜 API 쿼리문 수정하였습니다.
  • kr.idx, task.idx 정렬 조건 추가하였고, leftjoin으로 변경하였습니다.

📝 리뷰 노트

  • 빈 task가 들어가는 이슈는 response에는 제대로 값이 나오고 있어서 해당 PR까지 배포된 후 다시 테스트하고 동일한 이슈가 계속 있다면 바로 수정하겠습니다 ~

@0lynny 0lynny requested a review from its-sky June 1, 2024 14:26
@0lynny 0lynny self-assigned this Jun 1, 2024
its-sky
its-sky approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@its-sky its-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@0lynny 0lynny merged commit 363f17a into develop Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@its-sky its-sky its-sky approved these changes

Assignees

@0lynny 0lynny

Labels
영린🐣
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 소셜 API 버그 수정
2 participants
@0lynny @its-sky