Fix angleEdge at culled mesh boundaries
#580
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, `angleEdge` was simply copied from the base mesh to the culled mesh. With this change, `angleEdge` is flipped by pi radians if either the first cell on the given edge was removed (so the second cell is now the first cell after culling) or if only the second cell existed before (and after culling it is now the first cell). This is because `angleEdge` on a boundary edge always corresponds to a normal vector pointing from the first (and only) cell on the edge to the middle of the edge.
|
Unfortunately, this didn't fix reconstruction of a constant zonal velocity in my testing so I have more work to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix,
angleEdgewas simply copied from the base mesh to the culled mesh. With this change,angleEdgeis flipped by pi radians if either the first cell on the given edge was removed (so the second cell is now the first cell after culling) or if only the second cell existed before (and after culling it is now the first cell). This is becauseangleEdgeon a boundary edge always corresponds to a normal vector pointing from the first (and only) cell on the edge to the middle of the edge.