Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove broken assertions in debug runtime build
These assertions were defensive sanity checks from years ago when I was first working on the new block-based chunk system. The idea was to confirm the invariant that the frontier should always lie within the first block of the current chunk. However, these particular assertions are broken. Although unlikely, it's possible for frontier == limitPlusSlop, in which case the inSameBlock check will find two different blocks and therefore spuriously fail. We could fix these assertions... one idea would be to do something along the lines of assert(inSameBlock(frontier, limitPlusSlop-1) || frontier == limitPlusSlop) but then the assertion immediately following (sanity-checking the chunk magic number) would still be broken... So, for now, I'm just going to remove these assertions. I feel like these checks are ad-hoc/messy and should have been removed years ago in favor of a more careful treatment. The runtime system is in need of a refactor/cleanup, and perhaps this can be rolled into future code cleanup efforts.
- Loading branch information