Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mrchem 1.1.x do not install libraries any more #448

Open
susilehtola opened this issue Jan 22, 2023 · 2 comments
Open

mrchem 1.1.x do not install libraries any more #448

susilehtola opened this issue Jan 22, 2023 · 2 comments

Comments

@susilehtola
Copy link

The newer versions of mrchem install development headers, but have added OBJECT in 1a47fe1 which prevents the creation of distributable libraries. This is an issue for Linux distributions.

Moreover, it would be nice to have a standard sonamed shared library.
@stigrj
Copy link
Contributor

stigrj commented Jan 22, 2023

Any thoughts @robertodr ?

@robertodr
Copy link
Contributor

The thinking was that the library was only used to link to mrchem.x and nowhere else. Plus, there's no real API for MRChem and distributing a DSO for it didn't/doesn't really make sense. The development headers should not be installed, that CMake code is a leftover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@susilehtola @stigrj @robertodr