Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core hole calculations with MOM / IMOM #481

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

msnik1999
Copy link
Contributor

Adding functionality for modifying the orbital occupancies to allow core hole calculations, e.g. for XPS core binding energy calculations. @lratcliff
Also adding MOM/IMOM methods to assist these calculations.

@msnik1999
Copy link
Contributor Author

ToDo:

  • tests for unrestricted MOM/IMOM calculations
  • output depending on print level

@ilfreddy
Copy link
Contributor

ilfreddy commented Aug 7, 2024

  1. To make the test pass, you should first rebase so that you make sure your code also is compiling&testing the macos-12 build
  2. We should see what is missing to bring this from draft to mergeable PR
  3. Does this PR depend on the the corresponding one (fractional occupation numbers) in mrcpp?

@msnik1999 msnik1999 marked this pull request as ready for review August 19, 2024 13:22
@msnik1999
Copy link
Contributor Author

  1. To make the test pass, you should first rebase so that you make sure your code also is compiling&testing the macos-12 build

    1. We should see what is missing to bring this from draft to mergeable PR

    2. Does this PR depend on the the corresponding one (fractional occupation numbers) in mrcpp?

I think I addressed all issues and problems. This PR is dependent on the corresponding one in MRCPP.

@msnik1999 msnik1999 marked this pull request as draft August 28, 2024 12:04
@msnik1999 msnik1999 marked this pull request as ready for review September 3, 2024 14:26
@stigrj
Copy link
Contributor

stigrj commented Sep 3, 2024

The MRCPP PR is now merged, so you can update the GIT_TAG in external/upstream/fetch_mrcpp.cmake to the latest on master. Also, for the failing exchange issue, you can add an explicit exception somewhere in the initialization that fails whenever someone is trying to run MOM calculations with exact exchange. Then open an issue that explains the problem.

@msnik1999
Copy link
Contributor Author

The MRCPP PR is now merged, so you can update the GIT_TAG in external/upstream/fetch_mrcpp.cmake to the latest on master. Also, for the failing exchange issue, you can add an explicit exception somewhere in the initialization that fails whenever someone is trying to run MOM calculations with exact exchange. Then open an issue that explains the problem.

Done

@Gabrielgerez
Copy link
Contributor

Ill try resolving the conflict and we can probably just merge it after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants