Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros: Add missing dependencies #1284

Merged
merged 2 commits into from
Sep 12, 2023
Merged

ros: Add missing dependencies #1284

merged 2 commits into from
Sep 12, 2023

Conversation

wentasah
Copy link
Contributor

@wentasah wentasah commented Sep 3, 2023

Without these, the package cannot be built on NixOS.

Before merging this, please wait for this rosdep PR.


I acknowledge to have:

(Notify: @MRPT/owners )

Without these, the package cannot be built on NixOS.
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #1284 (8e22799) into develop (7ad256c) will not change coverage.
The diff coverage is n/a.

❗ Current head 8e22799 differs from pull request most recent head d67230d. Consider uploading reports for the commit d67230d to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1284   +/-   ##
========================================
  Coverage    40.18%   40.18%           
========================================
  Files         1235     1235           
  Lines       106807   106807           
========================================
  Hits         42918    42918           
  Misses       63889    63889           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad256c...d67230d. Read the comment docs.

@jlblancoc
Copy link
Member

Awesome, thanks! LGTM. Ping me when the rosdistro PR is merged.

@wentasah wentasah marked this pull request as ready for review September 12, 2023 16:12
@wentasah
Copy link
Contributor Author

ros/rosdistro#38406 has been merged so this can be too.

@jlblancoc jlblancoc merged commit f4748c9 into MRPT:develop Sep 12, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants