CWaypointsNavigator: stop aligning after wp is reached #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed apps/libraries
libs/nav/reactive/CWaypointsNavigator
PR Description
Fixed situation where robot tries to align with target even after the waypoint is considered as reached. For robots that do not support in-place alignment, this meant being stuck in place with an empty cmd_vel after stopping.
I acknowledge to have:
CONTRIBUTINGpagedoc/source/doxygen-docs/changelog.mdto describe these changes (if applicable)AUTHORS(if applicable)(Notify: @MRPT/owners )