Merge pull request #40 from jdevinemt/maestro

Actually fixed temporary file not deleted issue as well as missing binary execute permission issue
MaestroError · Mar 22, 2024 · cebe731 · cebe731
2 parents 1536658 + e60d70b
commit cebe731
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/bin/php-heic-to-jpg-linux-arm64 b/bin/php-heic-to-jpg-linux-arm64
diff --git a/composer.json b/composer.json
@@ -30,4 +30,4 @@
     "maestroerror/heif-converter": "0.2",
     "php": ">=7.4"
   }
-}
+}
diff --git a/src/HeicToJpg.php b/src/HeicToJpg.php
@@ -169,6 +169,9 @@ protected function processImage(string $source): void {
             $error = \is_array($output) ? implode("\\n", $output) : $output;
             // Try to convert with libheif
             if (!$this->tryToConvertWithLibheif($source, $newFileName)) {
+                if(file_exists($newFileName)){
+                    unlink($newFileName);
+                }
                 throw new \RuntimeException("Couldn't convert HEIC to JPG: '" . $error . "' | Bin used: '" . $this->exeName . "' HEIC: '" . $source . "' Full Command: '" . $command . "'" . " Output from heif-converter-image exe: " . $this->libheifOutput);
             }
         }