Only generate dialog markup if necessary

Magenerds · Apr 29, 2019 · b23dddf · b23dddf
1 parent d151ed2
commit b23dddf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/view/frontend/templates/modal_container.phtml b/view/frontend/templates/modal_container.phtml
@@ -18,7 +18,7 @@
 ?>
 
 <?php if ($this->showModal()): ?>
-    <div data-mage-init='{"countryModal":{"contentPath": "<?php echo $this->getModalContentUrl('popup/Popup/Index'); ?>"}}' id="language-modal" style="display:none;">
+    <div data-mage-init='{"countryModal":{"contentPath": "<?php echo $this->getModalContentUrl('popup/Popup/Index'); ?>"}}' id="language-modal" class="hide-country-popup" style="display:none;">
         <div class="img-wrapper">
             <img class="modal-image" />
         </div>

diff --git a/view/frontend/web/js/country_modal.js b/view/frontend/web/js/country_modal.js
@@ -78,11 +78,12 @@ define([
                     responsive: this.options.modal_responsive,
                     innerScroll: true,
                     wrapperClass: 'hint-country-modal'
-                },
-                popup = modal(options, this.element);
+                };
 
             if (!this.options.show_modal && !this.options.default_store) {
-                setTimeout(function () {
+                // only init modal dialog if necessary
+                modal(options, this.element);
+                this.element.removeClass('hide-country-popup');
                     that.element.modal('openModal', true);
                     if (!that.options.show_modal_overlay) {
                         $('.hint-country-modal').addClass('no-overlay');