-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to do an early stop? #87
Comments
It looks like checking the count doesn't make much sense if we can limit the size of the headers. How can I do it for |
Ok. Now I understand more. What I did doesn't make any sense.
httptools/httptools/parser/parser.pyx Lines 166 to 183 in e2d1a46
Still, I cannot do anything on Ref.: https://github.com/nodejs/node/tree/fd36a8dadba7fcbd74f0ab82a8ee1b3150ce5167/deps/llhttp/src (this is for myself) |
Hi there 👋
I'm trying to implement a flag
--limit-request-header-count
onuvicorn
, which I implemented changing the value of an attributetoo_many_headers
and raising an exception fromon_header
callback, see https://github.com/encode/uvicorn/pull/1683/files.My question is: is my implementation as intended? Should the
HttpParserCallbackError
send more information when an exception happens from one of the callbacks?The text was updated successfully, but these errors were encountered: