Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Cython 3.0+ #98

Closed
befeleme opened this issue Nov 13, 2023 · 4 comments
Closed

Support Cython 3.0+ #98

befeleme opened this issue Nov 13, 2023 · 4 comments

Comments

@befeleme
Copy link

In Fedora Linux, we've successfully built httptools with Cython 3.0.5 (see build log for details).
Would you consider unpinning the requirement on Cython < 3 in the project? I can send the PR.
@tacaswell
Copy link
Contributor

I can also confirm this.

Additionally, could you not include the generated c in the sdists? It causes problems when trying to install on newer versions of CPython.

@PaarthShah
Copy link

Yeah, I'm having trouble installing this on 3.13...

@DanielNoord
Copy link

Although not part of the project I think a PR would be welcome, as that is much easier to merge and review than doing that work yourself :)

tacaswell added a commit to tacaswell/httptools that referenced this issue Aug 2, 2024
@tacaswell
BLD: drop upper pin on cython
375ecd0 
closes MagicStack#98
@tacaswell tacaswell mentioned this issue Aug 2, 2024
Closed
fantix added a commit that referenced this issue Oct 14, 2024
@fantix
httptools 0.6.2
a2ed91d 
Fixes
=====

* Fix build and run tests on Python 3.13 (#107)
  (by @jameshilliard @tacaswell @fafanoulele @fantix in ad9765b for #98 #104)
@fantix fantix mentioned this issue Oct 14, 2024
Merged
@fantix
Copy link
Member

fantix commented Oct 14, 2024

Fixed in 0.6.2

@fantix fantix closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BLD: drop upper pin on cython tacaswell/httptools
5 participants
@tacaswell @fantix @DanielNoord @PaarthShah @befeleme