Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libuv to v1.46.0 #571

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Upgrade libuv to v1.46.0 #571

merged 2 commits into from
Oct 13, 2023

Conversation

fantix
Copy link
Member

@fantix fantix commented Oct 10, 2023

(CPython code snippet of subprocess.py:)

            if (_USE_POSIX_SPAWN
                    and os.path.dirname(executable)
                    and preexec_fn is None
                    and not close_fds
                    and not pass_fds
                    and cwd is None
                    and (p2cread == -1 or p2cread > 2)
                    and (c2pwrite == -1 or c2pwrite > 2)
                    and (errwrite == -1 or errwrite > 2)
                    and not start_new_session
                    and process_group == -1
                    and gid is None
                    and gids is None
                    and uid is None
                    and umask < 0):
                self._posix_spawn(args, executable, env, restore_signals,
                                  p2cread, p2cwrite,
                                  c2pread, c2pwrite,
                                  errread, errwrite)
                return

@fantix fantix requested a review from 1st1 October 10, 2023 03:09
@fantix fantix marked this pull request as draft October 10, 2023 04:18
@fantix fantix marked this pull request as ready for review October 11, 2023 23:29
# provide explicit API to choose such implementation detail.
# Based on current (libuv 1.46) behavior, setting
# UV_PROCESS_SETUID or UV_PROCESS_SETGID would reliably make
# libuv fallback to use fork, so let's just use it for now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should make a PR to libuv to make it reliably configurable.

@fantix fantix merged commit 2e1978c into master Oct 13, 2023
13 checks passed
@fantix fantix deleted the libuv-1.46 branch October 13, 2023 00:39
@fantix fantix mentioned this pull request Oct 13, 2023
fantix added a commit that referenced this pull request Oct 13, 2023
Changes
=======

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)

* Upgrade libuv to v1.46.0 (#571)
  (by @fantix in 2e1978c for #571)

Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)
This was referenced Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants