better argument validation errors

MahdiBM · Jul 19, 2024 · bb8b234 · bb8b234
1 parent 89b24ff
commit bb8b234
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/Sources/EnumeratorMacroImpl/Arguments.swift b/Sources/EnumeratorMacroImpl/Arguments.swift
@@ -20,7 +20,7 @@ struct Arguments {
             throw MacroError.unacceptableArguments
         }
         if exprList.isEmpty {
-            throw MacroError.expectedAtLeastOneArgument
+            throw MacroError.expectedAtLeastOneValidArgument
         }
         for element in exprList {
             switch element.expression.kind {

diff --git a/Sources/EnumeratorMacroImpl/EnumeratorMacroType.swift b/Sources/EnumeratorMacroImpl/EnumeratorMacroType.swift
@@ -32,6 +32,8 @@ extension EnumeratorMacroType: MemberMacro {
             arguments: arguments,
             context: context
         )
+
+        /// Validate comments
         if let allowedComments = parsedArguments.allowedComments,
            !allowedComments.keys.isEmpty {
 

diff --git a/Sources/EnumeratorMacroImpl/MacroError.swift b/Sources/EnumeratorMacroImpl/MacroError.swift
@@ -5,7 +5,7 @@ enum MacroError: Error, CustomStringConvertible {
     case isNotEnum
     case macroDeclarationHasNoArguments
     case unacceptableArguments
-    case expectedAtLeastOneArgument
+    case expectedAtLeastOneValidArgument
     case invalidArgument
     case expectedNonInterpolatedStringLiteral
     case renderedSyntaxContainsErrors(String)
@@ -24,8 +24,8 @@ enum MacroError: Error, CustomStringConvertible {
             "macroDeclarationHasNoArguments"
         case .unacceptableArguments:
             "unacceptableArguments"
-        case .expectedAtLeastOneArgument:
-            "expectedAtLeastOneArgument"
+        case .expectedAtLeastOneValidArgument:
+            "expectedAtLeastOneValidArgument"
         case .invalidArgument:
             "invalidArgument"
         case .expectedNonInterpolatedStringLiteral:
@@ -55,8 +55,8 @@ enum MacroError: Error, CustomStringConvertible {
             "The macro declaration needs to have at least 1 String-Literal argument"
         case .unacceptableArguments:
             "The arguments passed to the macro were unacceptable"
-        case .expectedAtLeastOneArgument:
-            "At least one argument of type StaticString is required"
+        case .expectedAtLeastOneValidArgument:
+            "At least one valid argument is required"
         case .invalidArgument:
             "Invalid argument received"
         case .expectedNonInterpolatedStringLiteral: