Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[various] added FlutterAppAuthOAuthError to hold standard error codes that apps can reference #523

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

MaikuB
Copy link
Owner

@MaikuB MaikuB commented Aug 10, 2024

No description provided.

@MaikuB MaikuB merged commit 10d578f into master Aug 10, 2024
8 checks passed
@MaikuB MaikuB deleted the oautherrorcodes branch August 10, 2024 03:17
@SamCosta1
Copy link
Contributor

@MaikuB I think this type still needs exporting? I can't access it from an app consuming the library (I may be wrong though).

@MaikuB
Copy link
Owner Author

MaikuB commented Aug 12, 2024

No you're right, I forgot to do so. Will fix this soon

@MaikuB
Copy link
Owner Author

MaikuB commented Aug 13, 2024

Should be fixed as part of 7.0.0-dev.4. Does this mean you are using the prerelease then? If so, let me know how it goes as I'm on making this a stable release. Note I ended up exposing these as strings to make the experience of using these easier and is the more direct approach. Was thinking that if an identity provider provided other values that having an enhanced enum or a class would make the developer experience bit worse. Have an app right now that could get access_denied as the error and isn't part of the RFC/spec

@SamCosta1
Copy link
Contributor

Yeah I'm using the pre-release version, no issues so far! I think the ideas discussed on the other thread to have much more robust cross platform error handling is the way to go though even if that means an enhanced enum. I'm needing to detect the case where the error's caused by lack of network connection and it's non trivial. It'd be great if this was just exposed directly as an error case.

@SamCosta1
Copy link
Contributor

Also thanks for removing the unneeded nullability, you beat me to it I was planning on raising a PR! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants